New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789381 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BookmarkAppHelper::callback_ should distinguish between extension install failures and user-cancellations.

Project Member Reported by mcgreevy@google.com, Nov 29 2017

Issue description

At the moment, BookmarkAppHelper::callback_ is called with a null Extension* to signal both:

(a) extension installation failed
(b) user clicked "cancel" in the app install dialog.

We should distinguish between these to cases so that the AppBannerManager can take appropriate action.
 

Sign in to add a comment