Black bar when v1 or v2 chrome app snapped left or right. |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open one v1 or v2 chrome app and one other app. (2) Enter tablet mode. (3) Enter overview mode. (4) Drag the v1 or v2 chrome app to the left or right. What is the expected result? The v1 or v2 app should have its header. What happens instead? The v1 or v2 app does not have a header.
,
Nov 29 2017
,
Nov 29 2017
+oshima@
,
Nov 30 2017
It looks to me that schedule redraw is missing when exiting overview. wutao@ can you take a look?
,
Nov 30 2017
sammiequon@, does your cl fix the black bar also? https://chromium-review.googlesource.com/c/chromium/src/+/797681
,
Dec 1 2017
Re #5 - Yes it does.
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35c25b650620a1f97265327a251c4ba9140d554d commit 35c25b650620a1f97265327a251c4ba9140d554d Author: Sammie Quon <sammiequon@google.com> Date: Fri Dec 01 23:22:50 2017 cros: Paint headers for snap window when in both splitview and overview. Fix a bug where snapped windows in splitview while still in overview do not have their headers painted. Make CustomFrameViewAshBase look for splitview state changes, and repaint the header if the state is snap left or snap right. Test: ash_unittests CustomFrameViewAshTest.HeaderVisibility* Bug: 789378 Change-Id: I7ff65181134205544af2a717a3ee3e3797aa2ad2 Reviewed-on: https://chromium-review.googlesource.com/797681 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#521114} [modify] https://crrev.com/35c25b650620a1f97265327a251c4ba9140d554d/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/35c25b650620a1f97265327a251c4ba9140d554d/ash/frame/custom_frame_view_ash.h [modify] https://crrev.com/35c25b650620a1f97265327a251c4ba9140d554d/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/35c25b650620a1f97265327a251c4ba9140d554d/ash/frame/header_view.h
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f4945a77903579a6568bbf46fdd8eaeaf9da567 commit 9f4945a77903579a6568bbf46fdd8eaeaf9da567 Author: Sammie Quon <sammiequon@google.com> Date: Thu Dec 07 05:08:58 2017 cros: Paint headers for splitview snapped windows part 2. Missed a case for part 1 (https://chromium-review.googlesource.com/c/chromium/src/+/797681). After both snap, press F5 to return to one snap + overview. Snapped windows header is not shown. This is because on entering overview mode or switching from split view states happen when overview is starting, not when it is entered (IsSelecting() returns false in OnOverviewModeStarting), so remove that check. Test: manual, ash_unittests CustomFrameViewAshTest.HeaderVisibility Bug: 789378 Change-Id: I1f1589b359983dcc6a2db65be62cd185121411c0 Reviewed-on: https://chromium-review.googlesource.com/809757 Reviewed-by: Tao Wu <wutao@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#522344} [modify] https://crrev.com/9f4945a77903579a6568bbf46fdd8eaeaf9da567/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/9f4945a77903579a6568bbf46fdd8eaeaf9da567/ash/frame/custom_frame_view_ash.h [modify] https://crrev.com/9f4945a77903579a6568bbf46fdd8eaeaf9da567/ash/frame/custom_frame_view_ash_unittest.cc
,
Jan 10 2018
,
Jan 12 2018
sammiequon@, this one should be fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sammiequon@chromium.org
, Nov 29 2017150 KB
150 KB View Download