WebUSB notifications should use a fuzzier URL match |
||||
Issue descriptionChrome Version: 64.0.3278.0 OS: All desktop (except Windows) What steps will reproduce the problem? (1) Connect a USB device with a landing page URL like "https://example.com/foo". (2) Click on the notification to navigate to the landing page. (3) "https://example.com/foo" redirects to "https://example.com/foo/" (4) Connect another USB device (or remove and re-insert the first one) with the same landing page URL. What is the expected result? Nothing, since there is already a tab in the foreground which is navigated to the device's landing page. What happens instead? A new notification appears since "https://example.com/foo" != "https://example.com/foo/".
,
Dec 3
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c59c9c43360f9d1467eac55bca76bb88f337979b commit c59c9c43360f9d1467eac55bca76bb88f337979b Author: James Hollyer <jameshollyer@google.com> Date: Thu Dec 20 03:39:06 2018 WebUSB Notification Fuzzy URL comparisons improved the URL comparisons done when a USB device notification is created and clicked on to just compare the prefix or the url in the browser. Bug: 789365 Change-Id: Id2de0f850cd96337b20b6a325fc74dc9c4f6736a Reviewed-on: https://chromium-review.googlesource.com/c/1372792 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@google.com> Cr-Commit-Position: refs/heads/master@{#618099} [modify] https://crrev.com/c59c9c43360f9d1467eac55bca76bb88f337979b/chrome/browser/usb/web_usb_detector.cc [modify] https://crrev.com/c59c9c43360f9d1467eac55bca76bb88f337979b/chrome/browser/usb/web_usb_detector_unittest.cc
,
Dec 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by scheib@chromium.org
, Nov 30 2017