+huayinz@ added the sub-folder labels using a method in the native bookmarks manager (iirc)

+hannahs@/cleer@ for UX input on expected behavior for nested folders

If we want to count all the bookmarks (but not folders) in the sub-tree, we'll have to peek inside with TreeNode::children().

Currently the description just simply shows the number of children inside a folder, regardless of the child being a bookmark or a folder. This is definitely not correct.

hannahs@/cleer@:

We might have two options:
1) Recursively count the total number of bookmarks in sub folders
2) Only bookmarks in that folder but not subfolders

I personally prefer the option 1 since it gives more information.

As a side, should we consider adding number of sub folders in the description?

Option 1 seems more accurate to me too. Are there performance implications with that (ex. a heavily nested folder hierarchy), though?

I don't think we should show the number of folders as a separate count; that seems excessive to me.

Should we still include the sub-folders in the displayed count, and perhaps use "X items" instead of "X bookmarks"? 

Consider this hierarchy:

Mobile Bookmarks/
   Recipes/
      Breakfast/
         www.bagels.com
         www.toast.com
      Lunch/
         www.pizza.com
      Dinner/
         www.spaghetti.com
      anytime-food.com
   Movies/
      www.aliens.com
   Articles/
      www.wsj.com
      www.nytimes.com
      www.cnn.com
      www.bloomberg.com

What should the count for "Mobile Bookmarks" be? How about "Recipes"?

My personal expectation would be that we disregard folders and show the number of bookmarks that are direct or indirect children within the folder. So in that example, the "Mobile Bookmarks" count would be 10 and the "Recipes" count would be 5. How viable is that from the technical perspective?

It's viable, I just wanted to confirm that's the desired UX.

Here's what I would see as a user:

 _____________________________
|  Bookmarks                  |
------------------------------|
| Mobile Bookmarks (10)       |
|                             |
|                             |
 _____________________________
|  <-  Mobile bookmarks       |
------------------------------|
| Recipes (5)                 |
| Movies (1)                  |
| Articles (4)                |

 _____________________________
|  <-  Recipes                |
------------------------------|
| Breakfast(2)                |
| Lunch (1)                   |
| Dinner (1)                  |
| anytime-food.com            |

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01dd07ebdcb35bee82937466756231ef5c663dc6

commit 01dd07ebdcb35bee82937466756231ef5c663dc6
Author: Becky Zhou <huayinz@chromium.org>
Date: Mon Jan 08 19:53:38 2018

[Bookmarks] Recursively count bookmarks in a folder for the description

The bookmark count for the folder description was simply number of
children in the folder before. Changing this to count number of
bookmarks recursively on sub folders.

Bug:  789363 
Change-Id: Iea0d02146cc944e035e6ae58e26b682b4361cca2
Reviewed-on: https://chromium-review.googlesource.com/826466
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527721}
[modify] https://crrev.com/01dd07ebdcb35bee82937466756231ef5c663dc6/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java
[modify] https://crrev.com/01dd07ebdcb35bee82937466756231ef5c663dc6/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderRow.java
[modify] https://crrev.com/01dd07ebdcb35bee82937466756231ef5c663dc6/chrome/browser/android/bookmarks/bookmark_bridge.cc
[modify] https://crrev.com/01dd07ebdcb35bee82937466756231ef5c663dc6/chrome/browser/android/bookmarks/bookmark_bridge.h