New issue
Advanced search Search tips

Issue 789362 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Duplicate WebUSB notifications appear when multiple devices connected

Project Member Reported by reillyg@chromium.org, Nov 29 2017

Issue description

Chrome Version: 64.0.3278.0
OS: All desktop

What steps will reproduce the problem?
(1) Connect multiple WebUSB devices with the same landing page URL

What is the expected result?
A single notification suggesting the user visit the landing page to use their device.

What happens instead?
Each device creates its own notification.
 
Labels: -OS-Windows
Remove OS=Windows label since WebUSB notifications are disabled on that platform.

Comment 2 by scheib@chromium.org, Nov 30 2017

Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: jameshollyer@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7cf3101dcae06f6d27524f055cd75de20c7fa33

commit d7cf3101dcae06f6d27524f055cd75de20c7fa33
Author: James Hollyer <jameshollyer@chromium.org>
Date: Thu Jan 03 00:07:24 2019

Stop duplicates WebUSB notification

This change adds a list of notifications that are currently displayed and checks
that list for duplicates before displaying a new notification.

Bug:  789362 
Change-Id: I1f8025dbb237da35b088de5bd6f21e80a1bbec52
Reviewed-on: https://chromium-review.googlesource.com/c/1373436
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619541}
[modify] https://crrev.com/d7cf3101dcae06f6d27524f055cd75de20c7fa33/chrome/browser/usb/web_usb_detector.cc
[modify] https://crrev.com/d7cf3101dcae06f6d27524f055cd75de20c7fa33/chrome/browser/usb/web_usb_detector.h
[modify] https://crrev.com/d7cf3101dcae06f6d27524f055cd75de20c7fa33/chrome/browser/usb/web_usb_detector_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment