New issue
Advanced search Search tips

Issue 789354 link

Starred by 1 user
Status: Fixed
Owner:
toyoshim@chromium.org
Closed: Dec 2017
Cc:
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add metrics to measure loading usage of {back,fore}ground from {main,sub}frames

Project Member Reported by kinuko@chromium.org, Nov 29 2017 
Add metrics to measure loading usage of {back,fore}ground from {main,sub}frames

- # of requests
- # of bytes of responses

Maybe also with cross-origin/same-origin categorization for subframes.

Comment 1 by kinuko@chromium.org, Nov 29 2017

Cc: altimin@chromium.org

Comment 2 by toyoshim@chromium.org, Nov 29 2017

Status: Started (was: Untriaged)
ok, let me try to have this in m64 :)

Comment 3 by kinuko@chromium.org, Nov 29 2017

Description: Show this description

Comment 4 by kinuko@chromium.org, Nov 29 2017 

Thanks Toyoshima-san and sorry for a rush.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c

commit 1cb7ac27d5c7b1b51c3bc118c89f0becc513148c
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Sat Dec 02 06:18:22 2017

ResourceLoadScheduler: add traffic monitoring metrics

This patch adds TrafficMonitor to count number of resource
requests and bytes of received data. Data are counted
per-frame basis, and classified by main frame vs sub-frames,
and throttled vs not-throttled.

Bug:  789354 
Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff
Reviewed-on: https://chromium-review.googlesource.com/795482
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521202}
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadSchedulerTest.cpp
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1cb7ac27d5c7b1b51c3bc118c89f0becc513148c/tools/metrics/histograms/histograms.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b4497759f080c55d7da842ae2144a79417b67b6

commit 4b4497759f080c55d7da842ae2144a79417b67b6
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Dec 02 07:13:06 2017

Revert "ResourceLoadScheduler: add traffic monitoring metrics"

This reverts commit 1cb7ac27d5c7b1b51c3bc118c89f0becc513148c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 521202 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFjYjdhYzI3ZDVjN2IxYjUxYzNiYzExOGM4OWYwYmVjYzUxMzE0OGMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20%28dbg%29/115798

Original change's description:
> ResourceLoadScheduler: add traffic monitoring metrics
> 
> This patch adds TrafficMonitor to count number of resource
> requests and bytes of received data. Data are counted
> per-frame basis, and classified by main frame vs sub-frames,
> and throttled vs not-throttled.
> 
> Bug:  789354 
> Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff
> Reviewed-on: https://chromium-review.googlesource.com/795482
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521202}

Change-Id: I1e51232d6ff3f974b2447c3890d45e606af751f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  789354 
Reviewed-on: https://chromium-review.googlesource.com/804976
Cr-Commit-Position: refs/heads/master@{#521204}
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadSchedulerTest.cpp
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/4b4497759f080c55d7da842ae2144a79417b67b6/tools/metrics/histograms/histograms.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0

commit 83ff34c20780b9d3f8b8baa80a4c53e4077c54f0
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Sun Dec 03 17:39:33 2017

Reland "ResourceLoadScheduler: add traffic monitoring metrics"

Explicit PLATFORM_EXPORT for an inner class static method
was needed for Windows.

This is a reland of 1cb7ac27d5c7b1b51c3bc118c89f0becc513148c
Original change's description:
> ResourceLoadScheduler: add traffic monitoring metrics
>
> This patch adds TrafficMonitor to count number of resource
> requests and bytes of received data. Data are counted
> per-frame basis, and classified by main frame vs sub-frames,
> and throttled vs not-throttled.
>
> Bug:  789354 
> Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff
> Reviewed-on: https://chromium-review.googlesource.com/795482
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521202}

Bug:  789354 
Change-Id: I9cf5edb2c8af0b5ecc09bf0b4deaba90e9f3fd66
Tbr: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/804707
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521229}
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadSchedulerTest.cpp
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/83ff34c20780b9d3f8b8baa80a4c53e4077c54f0/tools/metrics/histograms/histograms.xml

Comment 8 by toyoshim@chromium.org, Dec 4 2017

Labels: Merge-Request-64
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/213268ef570a86b30f7b1478b4d83ad6f9afa012

commit 213268ef570a86b30f7b1478b4d83ad6f9afa012
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Mon Dec 04 11:33:29 2017

Report traffic usage from ResourceLoadScheduler only on the main thread.

* The current histogram code assumes single-threaded usage (hits
  thread kassertion if resource loading from workers frun).
* Currently we classify all non-main-resource requests as subframes, but
  it's not really true if we include non-main-thread traffic.

(This could be a temporary work-around fix)

Bug:  789354 
Change-Id: I321cc6a3cbc39cb10c2b4ad8c110760f839a282f
Reviewed-on: https://chromium-review.googlesource.com/805674
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521314}
[modify] https://crrev.com/213268ef570a86b30f7b1478b4d83ad6f9afa012/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp

Comment 10 by candr...@chromium.org, Dec 4 2017 

Please add affected OSs.

Comment 11 by toyoshim@chromium.org, Dec 5 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
It's platform independent Blink side change.
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 5 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by toyoshim@chromium.org, Dec 5 2017 

The reason of the revert was that a Windows bot that has a special FYI configuration failed to build.

I want to merge following two CLs together.
83ff34c20780b9d3f8b8baa80a4c53e4077c54f0 refs/heads/master@{#521229}
213268ef570a86b30f7b1478b4d83ad6f9afa012 refs/heads/master@{#521314}

Comment 14 by kbleicher@google.com, Dec 5 2017

Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 7 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a8b3d803e61191928fe0f6b6637938bf422684

commit 44a8b3d803e61191928fe0f6b6637938bf422684
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Dec 07 06:16:26 2017

Reland "ResourceLoadScheduler: add traffic monitoring metrics"

Explicit PLATFORM_EXPORT for an inner class static method
was needed for Windows.

This is a reland of 1cb7ac27d5c7b1b51c3bc118c89f0becc513148c
Original change's description:
> ResourceLoadScheduler: add traffic monitoring metrics
>
> This patch adds TrafficMonitor to count number of resource
> requests and bytes of received data. Data are counted
> per-frame basis, and classified by main frame vs sub-frames,
> and throttled vs not-throttled.
>
> Bug:  789354 
> Change-Id: I57f4b2d73565ba1687db0f0e04a5dc2cb1bfb3ff
> Reviewed-on: https://chromium-review.googlesource.com/795482
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521202}

Bug:  789354 
Change-Id: I9cf5edb2c8af0b5ecc09bf0b4deaba90e9f3fd66
Tbr: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/804707
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521229}(cherry picked from commit 83ff34c20780b9d3f8b8baa80a4c53e4077c54f0)
Reviewed-on: https://chromium-review.googlesource.com/813317
Cr-Commit-Position: refs/branch-heads/3282@{#71}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadSchedulerTest.cpp
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.h
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/44a8b3d803e61191928fe0f6b6637938bf422684/tools/metrics/histograms/histograms.xml
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35f19b680f292b60dd0a1abd9fc7e52556c75ad4

commit 35f19b680f292b60dd0a1abd9fc7e52556c75ad4
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Dec 07 06:18:14 2017

Report traffic usage from ResourceLoadScheduler only on the main thread.

* The current histogram code assumes single-threaded usage (hits
  thread kassertion if resource loading from workers frun).
* Currently we classify all non-main-resource requests as subframes, but
  it's not really true if we include non-main-thread traffic.

(This could be a temporary work-around fix)

Bug:  789354 
Change-Id: I321cc6a3cbc39cb10c2b4ad8c110760f839a282f
Reviewed-on: https://chromium-review.googlesource.com/805674
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521314}(cherry picked from commit 213268ef570a86b30f7b1478b4d83ad6f9afa012)
Reviewed-on: https://chromium-review.googlesource.com/813515
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#72}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/35f19b680f292b60dd0a1abd9fc7e52556c75ad4/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp

Comment 17 by toyoshim@chromium.org, Dec 7 2017

Status: Fixed (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3140e8ad69f71c2cb6252c64cba62b6362105d2e

commit 3140e8ad69f71c2cb6252c64cba62b6362105d2e
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Jan 09 07:10:03 2018

ResourceLoadScheduler: ignore zero request frames in metrics

Blink seems to have several cases to create DocumentLoader not for an
actual page load. E.g., per XMLHttpRequest for "document" type response.
This causes creating many inactive ResourceLoadScheduler that report 0
as a total request count, and makes metrics hard to analyze.

This patch stops reporting metrics in a case that no request is recorded.

Also, this patch sets the initial throttling state to kNotThrottled even
when the field study is disabled to be have better result comparisons.

Bug:  789354 
Change-Id: I54f42935de70f0e89554dbbf61897b6ca8fde78e
Reviewed-on: https://chromium-review.googlesource.com/842523
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527920}
[modify] https://crrev.com/3140e8ad69f71c2cb6252c64cba62b6362105d2e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3803b96fd3d113616e2918e466a4535a7eefdb7e

commit 3803b96fd3d113616e2918e466a4535a7eefdb7e
Author: Alexander Timin <altimin@chromium.org>
Date: Wed Jan 10 13:58:33 2018

[loading] Add per-frame status network metrics

Record total size of requests split per frame status. This will allow us
to understand which proportion of network usage comes from background
tabs and offscreen frames.

R=toyoshim@chromium.org,kinuko@chromium.org,holte@chromium.org

Bug:  789354 
Change-Id: I714e6725fb4c3907643c3c5b7292327467f80115
Reviewed-on: https://chromium-review.googlesource.com/834008
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528297}
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/scheduler/util/aggregated_metric_reporter.h
[add] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/scheduler/util/task_duration_metric_reporter.cc
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/third_party/WebKit/Source/platform/scheduler/util/task_duration_metric_reporter.h
[modify] https://crrev.com/3803b96fd3d113616e2918e466a4535a7eefdb7e/tools/metrics/histograms/histograms.xml
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c91d429fa7708bedaba0ecb471dc96acd2fc961

commit 9c91d429fa7708bedaba0ecb471dc96acd2fc961
Author: Camille Lamy <clamy@chromium.org>
Date: Wed Jan 10 16:05:57 2018

Revert "[loading] Add per-frame status network metrics"

This reverts commit 3803b96fd3d113616e2918e466a4535a7eefdb7e.

Reason for revert: Broke MSAN build (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/5414)

Original change's description:
> [loading] Add per-frame status network metrics
> 
> Record total size of requests split per frame status. This will allow us
> to understand which proportion of network usage comes from background
> tabs and offscreen frames.
> 
> R=​toyoshim@chromium.org,kinuko@chromium.org,holte@chromium.org
> 
> Bug:  789354 
> Change-Id: I714e6725fb4c3907643c3c5b7292327467f80115
> Reviewed-on: https://chromium-review.googlesource.com/834008
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528297}

TBR=kinuko@chromium.org,toyoshim@chromium.org,holte@chromium.org,altimin@chromium.org

Change-Id: Ifb391465c810adb161ea79ec3c5c8a0f7275bb2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  789354 
Reviewed-on: https://chromium-review.googlesource.com/860457
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528329}
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[delete] https://crrev.com/f11f9437c10af943f3770cd7bba3c0eb2b4b15c2/third_party/WebKit/Source/platform/scheduler/util/aggregated_metric_reporter.h
[delete] https://crrev.com/f11f9437c10af943f3770cd7bba3c0eb2b4b15c2/third_party/WebKit/Source/platform/scheduler/util/task_duration_metric_reporter.cc
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/third_party/WebKit/Source/platform/scheduler/util/task_duration_metric_reporter.h
[modify] https://crrev.com/9c91d429fa7708bedaba0ecb471dc96acd2fc961/tools/metrics/histograms/histograms.xml
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35757f3b1974eed23d90f55d490e8d8f42949013

commit 35757f3b1974eed23d90f55d490e8d8f42949013
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Jan 15 14:09:22 2018

Reland "[loading] Add per-frame status network metrics"

This is a reland of 3803b96fd3d113616e2918e466a4535a7eefdb7e
Original change's description:
> [loading] Add per-frame status network metrics
>
> Record total size of requests split per frame status. This will allow us
> to understand which proportion of network usage comes from background
> tabs and offscreen frames.
>
> R=toyoshim@chromium.org,kinuko@chromium.org,holte@chromium.org
>
> Bug:  789354 
> Change-Id: I714e6725fb4c3907643c3c5b7292327467f80115
> Reviewed-on: https://chromium-review.googlesource.com/834008
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528297}

TBR=toyoshim@chromium.org,kinuko@chromium.org,holte@chromium.org

Bug:  789354 
Change-Id: I4512a4814b451d94c9fb860d6f0fdea9d40e9577
Reviewed-on: https://chromium-review.googlesource.com/864442
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529268}
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/scheduler/util/aggregated_metric_reporter.h
[add] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/scheduler/util/task_duration_metric_reporter.cc
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/third_party/WebKit/Source/platform/scheduler/util/task_duration_metric_reporter.h
[modify] https://crrev.com/35757f3b1974eed23d90f55d490e8d8f42949013/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment