[Mac] Views implementation of user menu button appears under stoplight buttons in RTL |
|||
Issue descriptionChrome Version: 64.0.3279.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Launch in RTL mode (I have #force-ui-direction, #force-text-direction, and #mac-rtl enabled) What is the expected result? The user menu button should appear to the right of the stoplight buttons. What happens instead? The user menu button appears beneath the stoplight buttons
,
Nov 29 2017
Is the views menu shipping by default in 64?
,
Nov 29 2017
Yes, their plan is to ship this in M64.
,
Nov 29 2017
On second look, the stoplights shouldn't be there in a legit RTL situation (10.12+) Try Cocoa browser/Safari/TextEdit/etc. with either -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES or switching to Arabic/Hebrew and logging in/out of your macOS user. So I think the larger issue is views stoplight location.
,
Nov 29 2017
Hi lgrey, Can you explain what you mean? I didn't follow about the stoplights should not be there (shouldn't they in RTL) or what you mean by "So I think the larger issue is views stoplight location".
,
Nov 30 2017
Sorry, I initially got confused and thought this was MacViews browser. Two issues: 1) For CocoaBrowser, #force-ui-direction, #force-text-direction, and #mac-rtl isn't a good test invocation because there's a bunch of things (stoplight location, natural text direction) that don't get triggered that way. If you launch with -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES #force-ui-direction #mac-rtl (or do the RTL language login dance) you should see something like the attached screenshot. 2) When I was confused and thought we were talking about MacViews browser, I built it and noticed it doesn't reposition the stoplights to the right with the correct RTL flags (so it looks like your screenshot).
,
Nov 30 2017
OK, thanks for the explanation (and sorry for the confusion - the RTL stuff is a little mind-bending at times). So this bug should be closed, correct?
,
Nov 30 2017
There should probably be a separate bug for MacViews browser (maybe there is?) but I'm sure it won't escape our notice by the time we get there, so agreed.
,
Nov 30 2017
,
Dec 6 2017
Issue 792403 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ajha@chromium.org
, Nov 29 2017