New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789347 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac] Pinned tab favicon slides out of view in RTL

Project Member Reported by shrike@chromium.org, Nov 29 2017 
Chrome Version: 64.0.3280.0
OS: macOS 10.12

What steps will reproduce the problem?
(1) Launch in RTL mode (I have #force-ui-direction, #force-text-direction, and #mac-rtl enabled)
(2) Visit apple.com
(3) Control-click the apple.com tab in the tabstrip and choose Pin Tab from the contextual menu

What is the expected result?
The tab should shrink in width and display the apple.com favicon centered within it.

What happens instead?
The tab is blank.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/283bc3ac9286fa1f07afaa6fd092e1b9f6821138

commit 283bc3ac9286fa1f07afaa6fd092e1b9f6821138
Author: Jayson Adams <shrike@chromium.org>
Date: Tue Dec 05 21:26:57 2017

[Mac] Fix favicon disappearing in pinned tabs in RTL.

In RTL mode a tab transitioning from non-pinned to pinned ends up with
no visible favicon. This cl fixes this problem, and also uses the
correct tab width to calculate the iconview's position in non-pinned
RTL mode.

Bug:  789347 
Change-Id: I972ef71c47811f9b2a5cf6ca2ac5f2c654d0c2bc
Reviewed-on: https://chromium-review.googlesource.com/795151
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521835}
[modify] https://crrev.com/283bc3ac9286fa1f07afaa6fd092e1b9f6821138/chrome/browser/ui/cocoa/tabs/tab_controller.mm
[modify] https://crrev.com/283bc3ac9286fa1f07afaa6fd092e1b9f6821138/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
[modify] https://crrev.com/283bc3ac9286fa1f07afaa6fd092e1b9f6821138/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Comment 2 by shrike@chromium.org, Dec 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment