New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789338 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Crash when running cross-origin-shared-worker-allowed.html with --site-per-process

Project Member Reported by lukasza@chromium.org, Nov 29 2017

Issue description

Site Isolation Linux FYI bot is red since https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/23126

There are crashes in the following layout tests:
* external/wpt/secure-contexts/basic-shared-worker.html
* external/wpt/secure-contexts/basic-shared-worker.https.html
* external/wpt/secure-contexts/shared-worker-insecure-first.https.html
* external/wpt/secure-contexts/shared-worker-secure-first.https.html
* http/tests/security/cross-origin-shared-worker-allowed.html
* virtual/cors-rfc1918/http/tests/security/cors-rfc1918/addressspace-sharedworker-basic.html
* virtual/mojo-loading/http/tests/security/cross-origin-shared-worker-allowed.html

Unfortunately, no symbols can be seen in callstacks shown in layout test results at https://storage.googleapis.com/chromium-layout-test-archives/Site_Isolation_Linux/23126/layout-test-results/results.html.

To run layout tests with --site-per-process use something like:
$ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -t <YOUR BUILD DIR - e.g. gn> --no-retry --additional-drt-flag=--site-per-process <TEST TO RUN>
 
Cc: thakis@chromium.org
thakis@ - I wonder if no symbols in crash callstack is a known issue?
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
jochen@ - I wonder if you could PTAL?  Your CL (r519603) is the only one from the blamelist that seems somewhat related.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f59a790e19f97e8bbdbb6e7960883c1e1cf0234

commit 4f59a790e19f97e8bbdbb6e7960883c1e1cf0234
Author: Jochen Eisinger <jochen@chromium.org>
Date: Wed Nov 29 10:09:33 2017

Walk frame tree to find main frame

When running with full site isolation, using the (deprecated) route via
the RVH doesn't work

BUG= 789338 
R=dcheng@chromium.org

Change-Id: Iba8fdf050933a3fae05734e91d2360432738fd3d
Reviewed-on: https://chromium-review.googlesource.com/795716
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520060}
[modify] https://crrev.com/4f59a790e19f97e8bbdbb6e7960883c1e1cf0234/content/browser/shared_worker/shared_worker_service_impl.cc

Comment 4 by jochen@chromium.org, Nov 29 2017

Status: Fixed (was: Assigned)

Comment 5 by jochen@chromium.org, Nov 30 2017

Cc: falken@chromium.org dullweber@chromium.org jochen@chromium.org mek@chromium.org raymes@chromium.org
 Issue 789830  has been merged into this issue.

Sign in to add a comment