desktop-pwas: Going backwards to an in-scope URL results in the app opening |
||
Issue descriptionWhat steps will reproduce the problem? (1) Go to g-ortuno.github.io/pwa-sandbox/ and install it (2) Navigate to g-ortuno.github.io/pwa-sandbox/ by typing it in the omnibox (3) Click "Continuous redirect" (4) Wait for the page to redirect (5) Press the back button What is the expected result? Tab should navigate to g-ortuno.github.io/pwa-sandbox/in-scope.html What happens instead? App window opens
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f60f086a4cf5d1297fbbc0dcc8a3da9178288530 commit f60f086a4cf5d1297fbbc0dcc8a3da9178288530 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Nov 30 04:53:26 2017 desktop-pwas: Don't intercept address bar and back/forward navigations Pasting a link into the address bar and then navigating to it results in a LINK navigation instead of a TYPED navigation. The transition qualifier for the navigation will be FROM_ADDRESS_BAR so we use that to distinguish it from regular link navigations. Back/Forward navigations have the same type as the original navigation e.g. if a navigation to "a.com" was a LINK navigation then navigating back or forward to "a.com" again will be a LINK navigation as well. This could cause us to incorrectly open an app window. Bug: 789328 , 782004 Change-Id: I5b53211bfbe144fc596ae7a1ac542e771e3c4f2b Reviewed-on: https://chromium-review.googlesource.com/795397 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#520443} [modify] https://crrev.com/f60f086a4cf5d1297fbbc0dcc8a3da9178288530/chrome/browser/extensions/bookmark_app_navigation_throttle.cc [modify] https://crrev.com/f60f086a4cf5d1297fbbc0dcc8a3da9178288530/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Nov 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ortuno@chromium.org
, Nov 28 2017Components: UI>Browser>WebAppInstalls
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows