[Chrome Home] "Open in New Tab" on article from NTP closes NTP |
||||||||
Issue descriptionChrome Version: current Chrome canary OS: Android What steps will reproduce the problem? (1) Open a New Tab Page (2) On the feed, identify an article you're interested in. (3) Long press on it and select open in new tab. What is the expected result? (4) The article appears in a new background tab. This is the current behavior on non-Chrome-Home. This works well because then I can continue scrolling down my feed and open other articles to read (all as background tabs). What happens instead? (4) The article appears in the current tab.
,
Nov 29 2017
The "new tab" concept in Chrome Home is different than the legacy concept. In Chrome Home, when the user opens a new tab, we open the bottom navigation panel on top of the tab switcher. This is not a real, fully-fledged "Tab" object, it's not written to the navigation history, and it is not persisted across (cold) restarts of Chrome. At step #4, we are opening a real Tab object (with navigation history, etc.) and closing the bottom navigation panel. On the Chrome Home NTP, long-press > open in new tab has the same behavior as tapping on article. This does seem incorrect to me. We could open the long-pressed article in a background tab and leave the Chrome Home navigation panel open if UX agrees that's the correct behavior.
,
Dec 1 2017
I agree that's what we should do. It doesn't make sense to make the open in new tab behavior identical to the tap once behavior.
,
Dec 1 2017
Moving to available. Kingston, please assign relative Fine-Pri for Chrome Home.
,
Dec 6 2017
Zine triage: this seems to be a Chrome Home issue, not NTP. Dropping the NTP label.
,
Dec 11 2017
,
Dec 11 2017
This is happening because we close the Chrome Home "NTP" when the tab switcher is exited. We currently exit the tab switcher when creating a new tab: 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.compositor.layouts.LayoutManagerChrome.startHiding(LayoutManagerChrome.java:356) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.compositor.layouts.Layout.startHiding(Layout.java:389) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.compositor.layouts.phone.StackLayout.onTabCreated(StackLayout.java:499) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.compositor.layouts.LayoutManagerChrome.tabCreated(LayoutManagerChrome.java:433) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.compositor.layouts.LayoutManagerChromePhone.tabCreated(LayoutManagerChromePhone.java:146) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.compositor.layouts.LayoutManagerChrome$LayoutManagerTabModelObserver.didAddTab(LayoutManagerChrome.java:112) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.tabmodel.TabModelImpl.addTab(TabModelImpl.java:169) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:159) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:82) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.ChromeTabbedActivity$TabbedModeTabCreator.createNewTab(ChromeTabbedActivity.java:359) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:64) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.openNewTab(TabModelSelectorImpl.java:321) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegateImpl.openUrlInNewTab(SuggestionsNavigationDelegateImpl.java:198) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegateImpl.openUrl(SuggestionsNavigationDelegateImpl.java:165) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegateImpl.openSnippet(SuggestionsNavigationDelegateImpl.java:150) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder.openItem(SnippetArticleViewHolder.java:78) 12-11 10:22:39.122 6666 6666 I cr_TMP : org.chromium.chrome.browser.ntp.ContextMenuManager$ItemClickListener.onMenuItemClick(ContextMenuManager.java:200) 12-11 10:22:39.122 6666 6666 I cr_TMP : com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:148) 12-11 10:22:39.122 6666 6666 I cr_TMP : com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:904) 12-11 10:22:39.122 6666 6666 I cr_TMP : com.android.internal.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:894) 12-11 10:22:39.122 6666 6666 I cr_TMP : com.android.internal.view.menu.MenuPopup.onItemClick(MenuPopup.java:128) I believe in order to "fix" this, we would have to change StackLayout#onTabCreated to add a new layout tab without hiding itself.
,
Feb 15 2018
,
Mar 21 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mpear...@chromium.org
, Nov 28 2017