kahlee: mosys crashes once on every boot |
||||||||||
Issue descriptionChrome OS Version: R64-10168.0.0 Chrome OS Platform: kahlee Steps To Reproduce: (1) Boot (2) grep mosys /var/log/messages (3) ls -al /var/spool/crash/ Expected Result: Nothing in /var/log/messages. Empty /var/spool/crash directory Actual Result: # grep -i mosys /var/log/messages 2017-11-28T15:31:42.518350-08:00 WARNING crash_reporter[2326]: [user] Received crash notification for mosys[2325] sig 6, user 0 (developer build - not testing - always dumping) 2017-11-28T15:31:42.538444-08:00 INFO crash_reporter[2326]: Stored minidump to /var/spool/crash/mosys.20171128.153142.2325.dmp 2017-11-28T15:31:42.540061-08:00 INFO crash_reporter[2326]: Leaving core file at /var/spool/crash/mosys.20171128.153142.2325.core due to developer image 2017-11-28T15:31:42.540732-08:00 WARNING crash_reporter[2326]: [ARC] Received crash notification for mosys[2325] sig 6, user 0 (ignoring - crash origin is not ARC) ### note this is ~15 seconds after boot # ls -al /var/spool/crash/ total 544 drwxr-xr-t. 2 root root 4096 Nov 28 15:25 . drwxr-xr-x. 5 root root 4096 Nov 20 16:27 .. -rw-r--r--. 1 root root 524288 Nov 28 15:25 mosys.20171128.152543.2253.core -rw-------. 1 root root 20056 Nov 28 15:25 mosys.20171128.152543.2253.dmp -rw-r--r--. 1 root root 112 Nov 28 15:25 mosys.20171128.152543.2253.meta How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Unknown
,
Nov 29 2017
,
Nov 29 2017
No, this SIGABRT is on 10168.0.0, and 786133 landed in 10166.0.0.
,
Nov 29 2017
Another possible clue: /var/log/powerd.out [1128/170051:ERROR:cros_config.cc(301)] Could not run command mosys -k platform id
,
Nov 29 2017
The specific invokation that is aborting is: mosys -l pd info When run at the command line it also shows: assertion failed in file drivers/google/cros_ec.c, line 167
,
Nov 29 2017
https://chromium.googlesource.com/chromiumos/platform/mosys/+/master/drivers/google/cros_ec.c#167 161 int cros_ec_chip_info(struct platform_intf *intf, struct ec_cb *ec, 162 struct ec_response_get_chip_info *info) 163 { 164 int rc = 0; 165 struct cros_ec_priv *priv; 166 167 MOSYS_CHECK(ec && ec->priv); 168 priv = ec->priv; 169 170 rc = priv->cmd(intf, ec,EC_CMD_GET_CHIP_INFO, 0, 171 info, sizeof(*info), NULL, 0); 172 if (rc) 173 return rc; 174 175 lprintf(LOG_DEBUG, "CrOS EC vendor: %s\n", info->vendor); 176 lprintf(LOG_DEBUG, "CrOS EC name: %s\n", info->name); 177 lprintf(LOG_DEBUG, "CrOS EC revision: %s\n", info->revision); 178 179 return rc; 180 }
,
Nov 29 2017
,
Dec 6 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/7616ddb3ab0405b75659383342db36faa0132263 commit 7616ddb3ab0405b75659383342db36faa0132263 Author: Simon Glass <sjg@chromium.org> Date: Mon Dec 11 03:47:30 2017 kahlee: reef: coral: fizz: Drop 'mosys pd' command This command does not work on these platforms as they do not have a PD (Power Delivery EC). Drop the command to avoid a crash. BUG= chromium:789322 BRANCH=none TEST=manual test on fizz and robo Change-Id: I07540991823be77758f5ec9a6aa627770c929b9d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/818078 Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> [modify] https://crrev.com/7616ddb3ab0405b75659383342db36faa0132263/platform/fizz/fizz.c [modify] https://crrev.com/7616ddb3ab0405b75659383342db36faa0132263/platform/reef/reef.c [modify] https://crrev.com/7616ddb3ab0405b75659383342db36faa0132263/platform/kahlee/kahlee.c
,
Dec 13 2017
Is this fixed? I'm seeing mosys crashes in a Chameleon test run: gpaste/5127408906665984, jclinton@ thinks it's related.
,
Dec 20 2017
,
Dec 20 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 20 2017
Re #11/12, We need this CL for 64 for Fizz, which is currently core dumping when running chromeos-firmwareup w/o the CL.
,
Dec 20 2017
Approving merge to M64 Chrome OS.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/9c36cfbf9bed275284fdc1f46935314abceb28cc commit 9c36cfbf9bed275284fdc1f46935314abceb28cc Author: Simon Glass <sjg@chromium.org> Date: Wed Dec 20 18:28:20 2017 kahlee: reef: coral: fizz: Drop 'mosys pd' command This command does not work on these platforms as they do not have a PD (Power Delivery EC). Drop the command to avoid a crash. BUG= chromium:789322 BRANCH=none TEST=manual test on fizz and robo Change-Id: I07540991823be77758f5ec9a6aa627770c929b9d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/818078 Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> (cherry picked from commit 7616ddb3ab0405b75659383342db36faa0132263) Reviewed-on: https://chromium-review.googlesource.com/837227 Reviewed-by: Shelley Chen <shchen@chromium.org> Commit-Queue: Shelley Chen <shchen@chromium.org> Tested-by: Shelley Chen <shchen@chromium.org> [modify] https://crrev.com/9c36cfbf9bed275284fdc1f46935314abceb28cc/platform/fizz/fizz.c [modify] https://crrev.com/9c36cfbf9bed275284fdc1f46935314abceb28cc/platform/reef/reef.c [modify] https://crrev.com/9c36cfbf9bed275284fdc1f46935314abceb28cc/platform/kahlee/kahlee.c
,
Jan 2 2018
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/9382c24478fa0b3752fbfc29f173e20b366820fb commit 9382c24478fa0b3752fbfc29f173e20b366820fb Author: Simon Glass <sjg@chromium.org> Date: Tue Mar 27 01:14:52 2018 kahlee: reef: coral: fizz: Drop 'mosys pd' command This command does not work on these platforms as they do not have a PD (Power Delivery EC). Drop the command to avoid a crash. BUG= chromium:789322 BRANCH=none TEST=manual test on fizz and robo Change-Id: I07540991823be77758f5ec9a6aa627770c929b9d Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/818078 Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> (cherry picked from commit 7616ddb3ab0405b75659383342db36faa0132263) Reviewed-on: https://chromium-review.googlesource.com/981206 Reviewed-by: Jason Clinton <jclinton@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/9382c24478fa0b3752fbfc29f173e20b366820fb/platform/fizz/fizz.c [modify] https://crrev.com/9382c24478fa0b3752fbfc29f173e20b366820fb/platform/reef/reef.c [modify] https://crrev.com/9382c24478fa0b3752fbfc29f173e20b366820fb/platform/kahlee/kahlee.c
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/9798d33e01886f8f1bea7b8a2cee778109f0b105 commit 9798d33e01886f8f1bea7b8a2cee778109f0b105 Author: Simon Glass <sjg@chromium.org> Date: Fri Apr 27 19:22:48 2018 Revert "kahlee: reef: coral: fizz: Drop 'mosys pd' command" Actually PD apparently refers to the USB-C power so the original CL here was incorrect. Also the crash in kahlee that was the original cause for concern does not happen on grunt (and we don't care about kahlee CDX03 anymore). This reverts commit 7616ddb3ab0405b75659383342db36faa0132263. BUG= chromium:789322 BRANCH=none BUG=b:78098518 TEST=try 'mosys pd chip 0' on santa, which works fine Change-Id: Ieae093b785be4cf56f0fd7a73a877a206311a8fa Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1031114 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/9798d33e01886f8f1bea7b8a2cee778109f0b105/platform/fizz/fizz.c [modify] https://crrev.com/9798d33e01886f8f1bea7b8a2cee778109f0b105/platform/reef/reef.c
,
Aug 3
Are these changes causing mosys crash on Fizz?Can anybody take a look at https://bugs.chromium.org/p/chromium/issues/detail?id=865174? |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by djkurtz@chromium.org
, Nov 28 2017# minidump_stackwalk /var/spool/crash/mosys.20171128.153142.2325.dmp Operating system: Linux 0.0.0 Linux 4.12.14-02816-g9ac67161aaeb #1 SMP PREEMPT Tue Nov 28 11:16:06 PST 2017 x86_64 CPU: amd64 family 21 model 112 stepping 0 1 CPU GPU: UNKNOWN Crash reason: SIGABRT Crash address: 0x0 Process uptime: not available Thread 0 (crashed) 0 libc-2.23.so + 0x33dd2 rax = 0x0000000000000000 rdx = 0x0000000000000006 rcx = 0x00007a70d8bdedd2 rbx = 0x0000585d8da71de0 rsi = 0x0000000000000915 rdi = 0x0000000000000915 rbp = 0x00007ffdcc356350 rsp = 0x00007ffdcc356228 r8 = 0x00007a70d917a780 r9 = 0x000000000000003b r10 = 0x0000000000000008 r11 = 0x0000000000000246 r12 = 0x0000585d8dad9388 r13 = 0x0000585d8dad3b20 r14 = 0x0000000000000000 r15 = 0x0000585d8dab6b17 rip = 0x00007a70d8bdedd2 Found by: given as instruction pointer in context 1 mosys + 0x29211 rbp = 0x00007ffdcc3563d0 rsp = 0x00007ffdcc356360 rip = 0x0000585d8da7c211 Found by: previous frame's frame pointer 2 mosys + 0x2a08f rbp = 0x00007ffdcc356470 rsp = 0x00007ffdcc3563e0 rip = 0x0000585d8da7d08f Found by: previous frame's frame pointer 3 mosys + 0x1ee9a rbp = 0x00007ffdcc3564f0 rsp = 0x00007ffdcc356480 rip = 0x0000585d8da71e9a Found by: previous frame's frame pointer 4 mosys + 0x1a57a rbp = 0x00007ffdcc356550 rsp = 0x00007ffdcc356500 rip = 0x0000585d8da6d57a Found by: previous frame's frame pointer 5 libc-2.23.so + 0x20736 rbp = 0x00007ffdcc356620 rsp = 0x00007ffdcc356560 rip = 0x00007a70d8bcb736 Found by: previous frame's frame pointer 6 mosys + 0x1a5b0 rbp = 0x00007ffdcc356620 rsp = 0x00007ffdcc356580 rip = 0x0000585d8da6d5b0 Found by: stack scanning 7 mosys + 0x5ff80 rbp = 0x00007ffdcc356620 rsp = 0x00007ffdcc356598 rip = 0x0000585d8dab2f80 Found by: stack scanning 8 ld-2.23.so + 0xfc0c rbp = 0x00007ffdcc356620 rsp = 0x00007ffdcc3565f0 rip = 0x00007a70d8f6ac0c Found by: stack scanning 9 mosys + 0x19d80 rbp = 0x00007ffdcc356620 rsp = 0x00007ffdcc356608 rip = 0x0000585d8da6cd80 Found by: stack scanning 10 mosys + 0x19da9 rsp = 0x00007ffdcc356630 rip = 0x0000585d8da6cda9 Found by: stack scanning 11 0x7ffdcc3b6000 rsp = 0x00007ffdcc3566c8 rip = 0x00007ffdcc3b6000 Found by: stack scanning 12 mosys + 0x40 rsp = 0x00007ffdcc356708 rip = 0x0000585d8da53040 Found by: stack scanning 13 0x7a70d8f5b000 rsp = 0x00007ffdcc356738 rip = 0x00007a70d8f5b000 Found by: stack scanning 14 mosys + 0x19d80 rsp = 0x00007ffdcc356758 rip = 0x0000585d8da6cd80 Found by: stack scanning Loaded modules: 0x585d8da53000 - 0x585d8dacefff mosys ??? (main) (WARNING: No symbols, mosys, 35613599C4EE3E473B97057B7944FDD70) 0x7a70d8bab000 - 0x7a70d8d4bfff libc-2.23.so ??? (WARNING: No symbols, libc-2.23.so, AE93E5A29749801F01A582739F11BFCD0) 0x7a70d8f5b000 - 0x7a70d8f7efff ld-2.23.so ??? (WARNING: No symbols, ld-2.23.so, E8062D0344F25000CFB111E7279E41370) 0x7a70d9143000 - 0x7a70d9148fff libfmap.so.0.0.0 ??? 0x7a70d9153000 - 0x7a70d9155fff libuuid.so.1.3.0 ??? 0x7a70d915b000 - 0x7a70d9161fff libfdt-1.4.4.so ??? 0x7ffdcc3b6000 - 0x7ffdcc3b7fff linux-gate.so ???