New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789311 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros_config: "SMBIOS name Reef does not match Pyro" shouldn't be an ERROR

Project Member Reported by la...@chromium.org, Nov 28 2017

Issue description

As discussed.
 

Comment 1 by sjg@chromium.org, Jan 5 2018

Cc: bmgordon@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5cb8d03683c39a4ed0d58734bf7cc757bc6fdf84

commit 5cb8d03683c39a4ed0d58734bf7cc757bc6fdf84
Author: Simon Glass <sjg@chromium.org>
Date: Mon Jan 08 08:10:06 2018

chromeos-config: Don't log an error when SMBIOS name check fails

For reef we work through several entries in the SKU map. It is not an
error if the first one does not match. Change this to INFO.

BUG= chromium:789311 
TEST=none

Change-Id: If8e0ff59072d33949e221fadd5694a3779e6ce15
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/852515
Reviewed-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>

[modify] https://crrev.com/5cb8d03683c39a4ed0d58734bf7cc757bc6fdf84/chromeos-config/libcros_config/lookup.cc

Comment 3 by sjg@chromium.org, Jan 29 2018

Status: Fixed (was: Started)

Sign in to add a comment