New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789310 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 833194



Sign in to add a comment

CL Exonerator doesn't have ts-mon credentials, and doesn't set up ts-mon metrics.

Project Member Reported by pho...@chromium.org, Nov 28 2017

Issue description

CL Exonerator should be emitting a metric (/chrome/infra/chromeos/cbuildbot/cl_action) when it emits an 'exonerated' CLAction.

However, it doesn't have ts-mon credentials and doesn't set up ts-mon's metric sending thread, so it never even attempts to emit the metric, and wouldn't succeed if it did.

We should look into how chrome-infra sets up ts-mon in AppEngine apps; I seem to remember they have a solution for this.
 

Comment 1 by pho...@chromium.org, Nov 30 2017

Blockedon: 790742

Comment 2 by pho...@chromium.org, Mar 29 2018

Labels: CL-Exonerator
Status: Assigned (was: Untriaged)
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Blockedon: -790742
Cc: sergeybe...@chromium.org
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Per discussion with sergeyberezin@, we'll use raw ts-mon with autogen: hostnames instead of trying to get gae_ts_mon to work on the app engine flexible environment.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/68de0637debf5d8fff15ac0bd4324174b8eab141

commit 68de0637debf5d8fff15ac0bd4324174b8eab141
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 06 04:20:57 2018

flex_ts_mon: Initial commit

Added flex_ts_mon library for initializing ts-mon for Flex apps.

TEST=with later CL
BUG= chromium:789310 

Change-Id: I370fb432dd2874f53e504bd699f46ac92c26b5cb

[add] https://crrev.com/68de0637debf5d8fff15ac0bd4324174b8eab141/flex_ts_mon/setup.py
[add] https://crrev.com/68de0637debf5d8fff15ac0bd4324174b8eab141/flex_ts_mon/__init__.py

Comment 8 by pho...@chromium.org, Apr 15 2018

Blockedon: 833194
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/58dbecb60e4be66908fd3a34797156c975921900

commit 58dbecb60e4be66908fd3a34797156c975921900
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Apr 17 17:31:44 2018

cidblib: Add 'exonerations_performed' metric

Add a simple metric to count exonerations performed.

BUG= chromium:789310 
TEST=None

Change-Id: Ief48d5e53ef5e9fe7efba7f74b5897615c77a134

[modify] https://crrev.com/58dbecb60e4be66908fd3a34797156c975921900/exonerator/cidblib.py

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/7495f5fc78c24d48c4f5015a2e4fbe69fd323671

commit 7495f5fc78c24d48c4f5015a2e4fbe69fd323671
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Apr 17 17:32:30 2018

innocent_cls_precq: Add failures_examined metric

BUG= chromium:789310 
TEST=unit tests still pass

Change-Id: I0d3450b412f808aaad9ce18f7f03ab723eeea128

[modify] https://crrev.com/7495f5fc78c24d48c4f5015a2e4fbe69fd323671/exonerator/innocent_cls_precq.py

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 17 2018

Status: Fixed (was: Started)

Sign in to add a comment