Network throttling configs in traffic_setting.py are out of sync |
|||
Issue descriptionThe network throttling configs defined in traffic_setting.py (https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/traffic_setting.py) should be synced with NetworkManager.js (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js?q=NetworkConditionsSelector+package:%5Echromium$&l=123&dr=C) after we adjust the throttling as in go/devtools-network-throttling.
,
Nov 30 2017
,
Dec 1 2017
The categories are quite different between these two places. Do we just want to update these two settings? * REGULAR_3G --- use slow-3G setting in networkManager * GOOD_3G --- use fast-3G setting in networkManager
,
Dec 1 2017
If we already do the update in a CL, I think we should just update all the settings to match with devtool to avoid future confusion
,
Dec 1 2017
There was a setting file, which is pointed to by the traffic_setting.py originally. But that file got deleted. Do you remember how did you get the data of GPRS, WIFI, etc.? https://codereview.chromium.org/2938503002/diff/390001/third_party/WebKit/Source/devtools/front_end/mobile_throttling/NetworkConditionsSelector.js?context=10&column_width=80&tab_spaces=8
,
Dec 1 2017
I joined the team after those settings were added. CC @paulirish who might know the history behind those settings. I removed those other settings to simplify the tool.
,
Dec 2 2017
@nednguyen, sorry I don't have enough bandwidth to do the sync for now as well, but as it seems not blocking any project, it's not urgent to make this change I think. We can wait till we have enough bandwidth. |
|||
►
Sign in to add a comment |
|||
Comment 1 by nedngu...@google.com
, Nov 30 2017