Issue metadata
Sign in to add a comment
|
Remove SetPrefServiceForTest method in ash::AccessibilityController |
||||||||||||||||||||||||
Issue descriptionIt was removed by jamescook@ in this CL: [1] and brought back in my CL in [2] to please accessibility_manager_browsertest for the time being. We should remove it by rephrasing code. [1] https://chromium-review.googlesource.com/c/chromium/src/+/761409 [2] https://chromium-review.googlesource.com/c/chromium/src/+/777780
,
Jan 19 2018
,
Jan 21 2018
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f18014946ec95189e02d36dc6bae8c6112cf5016 commit f18014946ec95189e02d36dc6bae8c6112cf5016 Author: Qiang Xu <warx@google.com> Date: Thu Feb 08 01:23:48 2018 cros: cleanup in AccessibilityManagerTest Changes: For signin screen to user session transition tests, using OobeBaseTest. And remove several ash/ includes in accessibility_manager_browsertest. Bug: 789285 Test: trybot tests Change-Id: Ief7b8b503ad60e2fcc60d7ea6312ee35763073b3 Reviewed-on: https://chromium-review.googlesource.com/858938 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#535235} [modify] https://crrev.com/f18014946ec95189e02d36dc6bae8c6112cf5016/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/f18014946ec95189e02d36dc6bae8c6112cf5016/ash/accessibility/accessibility_controller.h [modify] https://crrev.com/f18014946ec95189e02d36dc6bae8c6112cf5016/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
,
Feb 8 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Nov 29 2017