New issue
Advanced search Search tips

Issue 789282 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
STS
Team-Accessibility



Sign in to add a comment

[Select-to-Speak] The "did you mean to go to" alert from the omnibox throws off locations

Project Member Reported by katie@chromium.org, Nov 28 2017

Issue description

(On a device on the corp network...)
Search google for "potato"
Get a notification from the omnibox, "Did you mean to go to http://potato/?"
Highlight text further down the screen. It's off by the height of the notification bar.

See attached screenshot -- highlight and focus ring are off.

This does NOT seem to influence ChromeVox.

 
Screenshot from 2017-11-28 14:12:10.png
258 KB View Download

Comment 1 by katie@chromium.org, Nov 28 2017

Cc: dtseng@chromium.org
Actually maybe this does impact ChromeVox as well -- once I closed the notification, ChromeVox's bounds were all off by the same distance in the other direction.

Comment 2 by lpalmaro@google.com, Nov 29 2017

Labels: STS

Comment 3 by katie@chromium.org, Dec 11 2017

Owner: katie@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c28658521df0eee696b38c677433a9086091325c

commit c28658521df0eee696b38c677433a9086091325c
Author: Katie Dektar <katydek@google.com>
Date: Wed Dec 13 02:13:28 2017

Fixes accessiblity updates in native views that scroll or animate.

Bug:  789920 , 778080 , 789282 

Change-Id: Ie4b9d18ffbff48602126f6a4024fdd39f49fe032
Reviewed-on: https://chromium-review.googlesource.com/815878
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523654}
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/view.cc
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/view.h
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/view_unittest.cc

Comment 5 by katie@chromium.org, Dec 13 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d06b722374fed663b8d5d604627160f5db2dc28

commit 4d06b722374fed663b8d5d604627160f5db2dc28
Author: Katie Dektar <katydek@google.com>
Date: Tue Dec 19 16:37:21 2017

Fixes accessiblity updates in native views that scroll or animate.

Bug:  789920 , 778080 , 789282 

Change-Id: Ie4b9d18ffbff48602126f6a4024fdd39f49fe032
Reviewed-on: https://chromium-review.googlesource.com/815878
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523654}(cherry picked from commit c28658521df0eee696b38c677433a9086091325c)
Reviewed-on: https://chromium-review.googlesource.com/832380
Cr-Commit-Position: refs/branch-heads/3282@{#295}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/view.cc
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/view.h
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/view_unittest.cc

Sign in to add a comment