[Media Router] Improve sink availability tracking |
||
Issue descriptionRight now we start/stop observing for sinks with all the MRPs when we update the sink availability for one MRP. Instead, we should start/stop observing just for that one MRP.
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3 commit a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3 Author: Thomas Anderson <thomasanderson@chromium.org> Date: Tue Dec 05 01:03:06 2017 Revert "[Media Router] Better sink availability tracking" This reverts commit 52dda1185f5f801b7f16bc79be6696b297cbf3d4. Reason for revert: Breaks Linux x64 build: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F54249%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277 , 777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} TBR=imcheng@chromium.org,takumif@chromium.org Change-Id: Id4d13f0b2097ccfe398b05ce239d21c5d3c2b626 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789277 , 777650 Reviewed-on: https://chromium-review.googlesource.com/807588 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521561} [modify] https://crrev.com/a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3/chrome/browser/media/router/mojo/media_router_mojo_impl.h [modify] https://crrev.com/a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3/chrome/browser/media/router/mojo/wired_display_media_route_provider.cc [modify] https://crrev.com/a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3/chrome/browser/media/router/mojo/wired_display_media_route_provider.h [modify] https://crrev.com/a5e10914c8dda2b007a84d9fa12c0c47d6bc8bf3/chrome/browser/media/router/mojo/wired_display_media_route_provider_unittest.cc
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f517e020a1a30c6b192b4556f421f1203c7b61b9 commit f517e020a1a30c6b192b4556f421f1203c7b61b9 Author: Ojan Vafai <ojan@chromium.org> Date: Tue Dec 05 01:06:13 2017 Revert "[Media Router] Better sink availability tracking" This reverts commit 52dda1185f5f801b7f16bc79be6696b297cbf3d4. Reason for revert: Broke compile on linux. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F54249%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/54249 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/80407 https://uberchromegw.corp.google.com/i/chromium.gpu/builders/GPU%20Mac%20Builder/builds/108044 Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277 , 777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} TBR=imcheng@chromium.org,takumif@chromium.org Change-Id: I437f1c196351de49b83941a905a17a7add698abc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789277 , 777650 Reviewed-on: https://chromium-review.googlesource.com/807589 Reviewed-by: Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521564}
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f552870a47fe6a86273cb0ba4d77b6f6ad5c085 commit 8f552870a47fe6a86273cb0ba4d77b6f6ad5c085 Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Dec 05 22:21:45 2017 Reland "[Media Router] Better sink availability tracking" This is a reland of 52dda1185f5f801b7f16bc79be6696b297cbf3d4 Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277 , 777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} Bug: 789277 , 777650 Change-Id: I0a2edc4af121fa675548f9d545bb6048b05e2f13 Reviewed-on: https://chromium-review.googlesource.com/809333 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#521858} [modify] https://crrev.com/8f552870a47fe6a86273cb0ba4d77b6f6ad5c085/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/8f552870a47fe6a86273cb0ba4d77b6f6ad5c085/chrome/browser/media/router/mojo/media_router_mojo_impl.h [modify] https://crrev.com/8f552870a47fe6a86273cb0ba4d77b6f6ad5c085/chrome/browser/media/router/mojo/wired_display_media_route_provider.cc [modify] https://crrev.com/8f552870a47fe6a86273cb0ba4d77b6f6ad5c085/chrome/browser/media/router/mojo/wired_display_media_route_provider.h [modify] https://crrev.com/8f552870a47fe6a86273cb0ba4d77b6f6ad5c085/chrome/browser/media/router/mojo/wired_display_media_route_provider_unittest.cc
,
Dec 7 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 5 2017