test-webkitpy modifies layers-overlay.html |
||||
Issue descriptionWhat steps will reproduce the problem? 1. In a clean checkout, run third_party/WebKit/Tools/Scripts/test-webkitpy 2. git status What is the expected result? No modified files in checkout What happens instead of that? modified: third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html Diff attached. Possibly related to http://crrev.com/c/776094?
,
Nov 29 2017
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e788b8db56676bf7b50a6035a7d2c8ecf307e288 commit e788b8db56676bf7b50a6035a7d2c8ecf307e288 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Wed Nov 29 05:29:47 2017 Revert "Update paint/invalidation/repaint-overlay/layers-overlay.html" This reverts commit f01abd361f464b1d49bd1a7940523148a117cd62. Reason for revert: Suspected that this broke webkit_python_tests on Win7 and Win10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/57755 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/57756 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/28086 Original change's description: > Update paint/invalidation/repaint-overlay/layers-overlay.html > > It is generated by a python test case > (TestRepaintOverlay.test_generate_repaint_overlay_html). > I should have updated it when changing repaint_overlay.py. > > Updated the test to fail and print a message if the file needs an > update. > > Bug: 789272 > Change-Id: I2e6ba6573788177dfbc09d2bd4d3d80023d4b21f > Reviewed-on: https://chromium-review.googlesource.com/794875 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519912} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I2b2f70665713c9c861d5b6726721e6aef99241af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789272 Reviewed-on: https://chromium-review.googlesource.com/795690 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520019} [modify] https://crrev.com/e788b8db56676bf7b50a6035a7d2c8ecf307e288/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay-expected.html [modify] https://crrev.com/e788b8db56676bf7b50a6035a7d2c8ecf307e288/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html [modify] https://crrev.com/e788b8db56676bf7b50a6035a7d2c8ecf307e288/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py
,
Nov 29 2017
Reopening due to revert.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e8ce1e925ec60c8b03f363c89347a192555a3ed commit 8e8ce1e925ec60c8b03f363c89347a192555a3ed Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Nov 29 18:30:06 2017 Reland "Update paint/invalidation/repaint-overlay/layers-overlay.html" This is a reland of f01abd361f464b1d49bd1a7940523148a117cd62 The original patch failed on Windows bots because there was no "/tmp" directory. This new patch saves the generated layers-overlay.html in the results directory (existence ensured). Original change's description: > Update paint/invalidation/repaint-overlay/layers-overlay.html > > It is generated by a python test case > (TestRepaintOverlay.test_generate_repaint_overlay_html). > I should have updated it when changing repaint_overlay.py. > > Updated the test to fail and print a message if the file needs an > update. > > Bug: 789272 > Change-Id: I2e6ba6573788177dfbc09d2bd4d3d80023d4b21f > Reviewed-on: https://chromium-review.googlesource.com/794875 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519912} TBR=pdr@chromium.org Bug: 789272 Change-Id: I17de00b123520be148bba4aacd923f21d3f18e9c Reviewed-on: https://chromium-review.googlesource.com/797110 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520171} [modify] https://crrev.com/8e8ce1e925ec60c8b03f363c89347a192555a3ed/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay-expected.html [modify] https://crrev.com/8e8ce1e925ec60c8b03f363c89347a192555a3ed/third_party/WebKit/LayoutTests/paint/invalidation/repaint-overlay/layers-overlay.html [modify] https://crrev.com/8e8ce1e925ec60c8b03f363c89347a192555a3ed/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py
,
Nov 29 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 29 2017