Webapp not sized correctly |
||||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 64.0.3280.0 Steps to reproduce: 1.) Navigate to news.google.com (or any webapp capable site) 2.) Add to homescreen 3.) Open link on the homescreen (try w/ killing chrome and without) Observed behavior: The content does not fill the screen, but seems to be height - toolbar Expected behavior: The contents should be full screen. Frequency: 10/10 Additional comments:
,
Nov 28 2017
,
Nov 29 2017
I'm clueless why I can't reproduce this bug.. but why it happens is clear - CCT/Webapp-hosted tabs should have fixed browser control info, unlike the tabs in Chrome. Their WebContentsDelegate however inherits from TabWebContentsDelegate, therefore inherits the dynamic browser control update feature too. This should be prevented by overriding again. https://chromium-review.googlesource.com/c/chromium/src/+/795479
,
Dec 1 2017
I got a clue - it has to do with the view size being updated along the way a tab is created. Looks like my CL set a valid view size sooner than it should , somehow it confused blink/cc. The problem goes away if the size is kept to zero till that point. I'm testing if the new fix doesn't have any other side effect.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/708d46e3653a5ae94414689b885051333bf59e35 commit 708d46e3653a5ae94414689b885051333bf59e35 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Dec 07 20:00:39 2017 Prevent CCT/Webapp tab from resizing incorrectly This CL removes a spurious |WebContents.setSize()| at the tab initialization that sets a wrong view size to fix the bug of giving a wrong view height for CCT/Webapp. Bug: 789260 Change-Id: Ie93e81b4fd9f1387e121105dd048c22015238f12 Reviewed-on: https://chromium-review.googlesource.com/795479 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522517} [modify] https://crrev.com/708d46e3653a5ae94414689b885051333bf59e35/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Dec 7 2017
,
Dec 8 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31dfbbc70b0a8fffd05952f4d02963b8933ac272 commit 31dfbbc70b0a8fffd05952f4d02963b8933ac272 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Mon Dec 11 01:18:16 2017 Prevent CCT/Webapp tab from resizing incorrectly This CL removes a spurious |WebContents.setSize()| at the tab initialization that sets a wrong view size to fix the bug of giving a wrong view height for CCT/Webapp. Bug: 789260 Change-Id: Ie93e81b4fd9f1387e121105dd048c22015238f12 Reviewed-on: https://chromium-review.googlesource.com/795479 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522517}(cherry picked from commit 708d46e3653a5ae94414689b885051333bf59e35) TBR=tedchoc@chromium.org Change-Id: Ie93e81b4fd9f1387e121105dd048c22015238f12 Reviewed-on: https://chromium-review.googlesource.com/818608 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#118} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/31dfbbc70b0a8fffd05952f4d02963b8933ac272/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Dec 11 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tedc...@chromium.org
, Nov 28 2017Owner: jinsuk...@chromium.org
Status: Assigned (was: Untriaged)