New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789259 link

Starred by 2 users
Status: Fixed
Owner:
cblume@chromium.org
Closed: May 2018
Cc:
danakj@chromium.org
samans@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
vmi...@chromium.org
sadrul@chromium.org
ericrk@chromium.org
piman@chromium.org
kylec...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 801350
issue 811944



Sign in to add a comment

Add a client ID to the surface ID

Project Member Reported by cblume@chromium.org, Nov 28 2017 
In order for a client to generate a new surface, it needs to be able to generate a new surface ID. Right not, it cannot do this.

We can add a client ID section to the overall surface ID. This will allow the client to generate a new surface ID by changing only the section it is allowed to change.

Comment 1 by fsamuel@google.com, Nov 28 2017

Cc: rjkroege@chromium.org sadrul@chromium.org kylec...@chromium.org piman@chromium.org danakj@chromium.org samans@chromium.org
So what will the components of SurfaceId be then?

Right now SurfaceId = (FrameSinkId, LocalSurfaceId).

LocalSurfaceId = (local_id, nonce).

I was thinking:

LocalSurfaceId => (parent_id, child_id, nonce) instead? WDYT?

Comment 2 by cblume@chromium.org, Nov 28 2017

Cc: vmi...@chromium.org
LocalSurfaceId => (parent_id, child_id, none) was my understanding as well.
I guess I didn't describe that well enough in the original comment. :)

Comment 3 by sadrul@chromium.org, Nov 28 2017 

FrameSinkId has a client id. Why do we need a second one?

Comment 4 by fsamuel@google.com, Nov 28 2017 

For synchronization purposes. The client ID portion of FrameSinkId is a fixed value for a particular client. The "Child ID" in LocalSurfaceId is a sequence number for synchronization that the child updates. Maybe child_sequence_number is a better name?

Comment 5 by sadrul@chromium.org, Nov 28 2017 

Isn't that what |local_id| is for? (sorry if this is naive)

Comment 6 by fsamuel@google.com, Nov 28 2017 

Yea, local_id => parent_id and a new child_id is being introduced. This roughly corresponds to Saman's design here:

https://docs.google.com/document/d/1Jz2TyiqPso6vjnAFPXW7A5mgusmdHFQXLLMVrwoWvgg/edit
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1cceea186f4ec7448c2b0bc9db37ed935aba75d

commit c1cceea186f4ec7448c2b0bc9db37ed935aba75d
Author: Chris Blume <cblume@google.com>
Date: Thu Nov 30 22:37:18 2017

Rename LocalSurfaceId::local_id() to parent_id()

The local_id is really the parent_id. And since we will soon be adding a
child_id to the mix, we should rename this to clarify.

BUG= 789259 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I29b48e21de5b1d137a4df4f4d9e9a3169e82c284
Reviewed-on: https://chromium-review.googlesource.com/794374
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520725}
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/common/surfaces/local_surface_id.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/common/surfaces/local_surface_id.h
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/frame_sinks/referenced_surface_tracker_unittest.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/services/viz/public/cpp/compositing/local_surface_id_struct_traits.h
[modify] https://crrev.com/c1cceea186f4ec7448c2b0bc9db37ed935aba75d/services/viz/public/interfaces/compositing/local_surface_id.mojom
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7375379aaf6be6005d07c1a46e10cf300f8db67f

commit 7375379aaf6be6005d07c1a46e10cf300f8db67f
Author: Chris Blume <cblume@google.com>
Date: Wed Dec 06 18:10:33 2017

Update comment describing parent_id

The semantics of this property change pre- and post- surface synchronization.

BUG= 789259 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I511d0c6fe2c465c7ef36076bd3b461f7d216a081
Reviewed-on: https://chromium-review.googlesource.com/808997
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522137}
[modify] https://crrev.com/7375379aaf6be6005d07c1a46e10cf300f8db67f/services/viz/public/interfaces/compositing/local_surface_id.mojom
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/121647d4d035fb7feaf075469d2e0e9905820476

commit 121647d4d035fb7feaf075469d2e0e9905820476
Author: Chris Blume <cblume@google.com>
Date: Thu Dec 07 22:47:50 2017

Add child_sequence_number to LocalSurfaceId

Eventually, we want the child to be able to allocate its own Surfaces.
In order to do this, the child will have a sequence number inside the
LocalSurfaceId to go along with the parent_id.

This patch adds child_sequence_number, but does nothing with it. It will
always be 0 for now. A later patch will allocate new Surfaces using the
child-generated child_sequence_number.

BUG= 789259 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I3bb04cb5b6f46b5efb5f186a9577da639b167d20
Reviewed-on: https://chromium-review.googlesource.com/807247
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522584}
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/components/viz/common/surfaces/local_surface_id.cc
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/components/viz/common/surfaces/local_surface_id.h
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/services/viz/public/cpp/compositing/local_surface_id_struct_traits.h
[modify] https://crrev.com/121647d4d035fb7feaf075469d2e0e9905820476/services/viz/public/interfaces/compositing/local_surface_id.mojom
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efd8f24b59021e8e780efd2546bbdf3024c71b93

commit efd8f24b59021e8e780efd2546bbdf3024c71b93
Author: Chris Blume <cblume@google.com>
Date: Fri Dec 08 00:24:27 2017

Rename LocalSurfaceIdAllocator

We eventually want to have separate allocators for the parent and the child.
Right now, with surface synchronization all of the allocation happens in
the parent. So rename LocalSurfaceIdAllocator to
ParentSurfaceIdAllocator. This will make room for
ChildSurfaceIdAllocator which will come later.

BUG= 789259 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9231eacad56953c827c7fa6550acb52d7db078a9
Reviewed-on: https://chromium-review.googlesource.com/809886
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522639}
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/android_webview/browser/surfaces_instance.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/client/client_layer_tree_frame_sink.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/client/local_surface_id_provider.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/client/local_surface_id_provider.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/common/BUILD.gn
[delete] https://crrev.com/70a740542455ff94e4da520a8c629112cff5f875/components/viz/common/surfaces/local_surface_id_allocator.cc
[delete] https://crrev.com/70a740542455ff94e4da520a8c629112cff5f875/components/viz/common/surfaces/local_surface_id_allocator.h
[add] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[add] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/common/surfaces/parent_local_surface_id_allocator.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/display/surface_aggregator_pixeltest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/frame_sinks/video_detector_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/services/ui/ws/display.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/services/ui/ws/frame_generator.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/services/ui/ws/window_manager_display_root.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/aura/local/window_port_local.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/compositor/compositor.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/compositor/compositor_unittest.cc
[modify] https://crrev.com/efd8f24b59021e8e780efd2546bbdf3024c71b93/ui/compositor/test/in_process_context_factory.cc

Comment 11 by ericrk@chromium.org, Feb 8 2018

Blocking: 801350
Labels: -Pri-3 OS-Android Pri-2
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89384e936f3e6d5f7517f206979730dd5aa0b69

commit a89384e936f3e6d5f7517f206979730dd5aa0b69
Author: Chris Blume <cblume@chromium.org>
Date: Fri Feb 09 08:09:00 2018

Add child ID allocator, allow parent updates

The parent allocator needs to be able to update its understanding of the
last child-generated LocalSurfaceId. This patch adds that functionality.

Additionally, this patch adds a child allocator which will be used
later. It must also be able to update its understanding of the last
parent-generated LocalSurfaceId.

BUG= 789259 

Change-Id: I3c32813460b566370d2f9d362596ffb6a0086f31
Reviewed-on: https://chromium-review.googlesource.com/907680
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535667}
[modify] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/BUILD.gn
[add] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/surfaces/child_local_surface_id_allocator.cc
[add] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/surfaces/child_local_surface_id_allocator.h
[add] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/surfaces/child_local_surface_id_allocator_unittest.cc
[modify] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[modify] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/surfaces/parent_local_surface_id_allocator.h
[add] https://crrev.com/a89384e936f3e6d5f7517f206979730dd5aa0b69/components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc

Comment 13 by ericrk@chromium.org, Feb 13 2018

Blocking: 811944
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54fcb1d19faa80571613c47c03e70f313f03ccbd

commit 54fcb1d19faa80571613c47c03e70f313f03ccbd
Author: Chris Blume <cblume@chromium.org>
Date: Fri Mar 02 18:51:53 2018

Add ScopedSurfaceIdAllocator

Adds a ScopedSurfaceIdAllocator which can be used to suppress
allocation of LocalSurfaceId in the parent during its lifetime.
When it is destroyed, it runs its own allocation.

BUG= 789259 , 805073 

Change-Id: I56d4435922031b625cdbcddb012f89b309b36ba1
Reviewed-on: https://chromium-review.googlesource.com/918405
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540569}
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/BUILD.gn
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/surfaces/parent_local_surface_id_allocator.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc
[add] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/surfaces/scoped_surface_id_allocator.cc
[add] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/surfaces/scoped_surface_id_allocator.h
[add] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/components/viz/common/surfaces/scoped_surface_id_allocator_unittest.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/content/test/mock_render_widget_host_delegate.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/BUILD.gn
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/local/window_port_local.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/window.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/window.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/window_port.h
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/54fcb1d19faa80571613c47c03e70f313f03ccbd/ui/aura/window_port_for_shutdown.h
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760b946849da9bd7a638418a762712f678a2e017

commit 760b946849da9bd7a638418a762712f678a2e017
Author: Chris Blume <cblume@chromium.org>
Date: Thu Apr 12 21:45:33 2018

Use new child surface allocation for resize case

This patch introduces a child allocator for surface IDs.
This allows a renderer to create a surface as it needs (such as when
creating the Cast dialog), as opposed to request a surface from the
parent.

BUG= 789259 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I36acec47f083dffd029aba56431eda720579e63e
Reviewed-on: https://chromium-review.googlesource.com/861643
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550373}
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/components/viz/common/surfaces/child_local_surface_id_allocator.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/common/view_messages.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_view_impl.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_widget.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_widget.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/test/mock_render_widget_host_delegate.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/test/mock_render_widget_host_delegate.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/local/window_port_local.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window_port.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window_port_for_shutdown.h
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f18f8124227f751f390b5aefe31c125a12194ed5

commit f18f8124227f751f390b5aefe31c125a12194ed5
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Apr 16 21:13:31 2018

Suppress surface ID allocations during autoresize for child frames

This change makes the ResizeDueToAutoResize messages for child frames
transactional, with a begin/end. It also ensures that during a
transaction we don't allocate new LocalSurfaceIds, instead waiting
for the transaction to complete.

Bug:  789259 , 805073 
Change-Id: I585ac6d14b9978280847f49205d03bf49b9bb4f8
Reviewed-on: https://chromium-review.googlesource.com/960981
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551114}
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/common/frame_messages.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/test/content_browser_test_utils_internal.h
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760b946849da9bd7a638418a762712f678a2e017

commit 760b946849da9bd7a638418a762712f678a2e017
Author: Chris Blume <cblume@chromium.org>
Date: Thu Apr 12 21:45:33 2018

Use new child surface allocation for resize case

This patch introduces a child allocator for surface IDs.
This allows a renderer to create a surface as it needs (such as when
creating the Cast dialog), as opposed to request a surface from the
parent.

BUG= 789259 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I36acec47f083dffd029aba56431eda720579e63e
Reviewed-on: https://chromium-review.googlesource.com/861643
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550373}
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/components/viz/common/surfaces/child_local_surface_id_allocator.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/components/viz/common/surfaces/parent_local_surface_id_allocator.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/common/view_messages.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_view_impl.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_widget.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_widget.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/test/mock_render_widget_host_delegate.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/content/test/mock_render_widget_host_delegate.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/local/window_port_local.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window_port.h
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/760b946849da9bd7a638418a762712f678a2e017/ui/aura/window_port_for_shutdown.h
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f18f8124227f751f390b5aefe31c125a12194ed5

commit f18f8124227f751f390b5aefe31c125a12194ed5
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Apr 16 21:13:31 2018

Suppress surface ID allocations during autoresize for child frames

This change makes the ResizeDueToAutoResize messages for child frames
transactional, with a begin/end. It also ensures that during a
transaction we don't allocate new LocalSurfaceIds, instead waiting
for the transaction to complete.

Bug:  789259 , 805073 
Change-Id: I585ac6d14b9978280847f49205d03bf49b9bb4f8
Reviewed-on: https://chromium-review.googlesource.com/960981
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551114}
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/common/frame_messages.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/f18f8124227f751f390b5aefe31c125a12194ed5/content/test/content_browser_test_utils_internal.h
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e

commit 12a2646d7f7df9ffcfff2b44dbb49ff58289d11e
Author: Chris Blume <cblume@chromium.org>
Date: Sun Apr 22 02:00:12 2018

Pass child allocated LSIs to Guests/ChildFrames

This change passes child allocated surface IDs from the browser to
ChildFrames / Guests. Additionally, it updates the existing ChildFrame
tests and adds Guest tests to ensure that:
- The ID we pass is correctly received.
- The Guest/ChildFrame does not have extra allocations.

Bug:  789259 , 805073 , 811944 
Change-Id: I82e0677d46801bfe721e30674493ffe0406d87e9
Reviewed-on: https://chromium-review.googlesource.com/996920
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552597}
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/browser_plugin/browser_plugin_message_filter.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/browser_plugin/browser_plugin_message_filter.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/common/frame_messages.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/public/test/browser_test_utils.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/12a2646d7f7df9ffcfff2b44dbb49ff58289d11e/content/test/content_browser_test_utils_internal.h

Comment 20 by cblume@chromium.org, May 13 2018

Status: Fixed (was: Started)
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6535d45903d9c80f4c783f602b5b2cf628368372

commit 6535d45903d9c80f4c783f602b5b2cf628368372
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Jun 18 18:45:01 2018

Surface synchronization: Check surface invariants on Android

We would like to start a Finch trial for surface sync on Android soon.
This CL re-enables Android-specific surface invariants violations checks
on Android by removing code in RenderWidgetHostImpl that bypasses those
checks. This CL also ensures that when the background transparency
changes a new LocalSurfaceId is allocated as this matches the behavior
pre-surface-sync.

Bug:  672962 ,  789259 ,  801350 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iad2dc6c508770314ea33eb53f05944609f29b0b9
Reviewed-on: https://chromium-review.googlesource.com/1104315
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568091}
[modify] https://crrev.com/6535d45903d9c80f4c783f602b5b2cf628368372/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/6535d45903d9c80f4c783f602b5b2cf628368372/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/6535d45903d9c80f4c783f602b5b2cf628368372/content/browser/renderer_host/render_widget_host_impl.h
►

Sign in to add a comment