Bug filed by Findit is hidden due to no priority set |
||||
Issue descriptionExample: https://screenshot.googleplex.com/bj4gPqLtVdq.png https://bugs.chromium.org/p/chromium/issues/detail?id=789088 https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKVAWNocm9taXVtLm1lbW9yeS9NYWMgQVNhbiA2NCBUZXN0cyAoMSkvMzYzNTUvY29udGVudF9icm93c2VydGVzdHMvVTJsMFpWQmxjbEJ5YjJObGMzTkNjbTkzYzJWeVZHVnpkQzVUWTNKdmJHeEdiMk4xYzJWa1JXUnBkR0ZpYkdWRmJHVnRaVzUwU1c1MGIxWnBaWGM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Since the result is very reliable -- newly-added flaky test and it will cause CQ overhead of compile/run without patch, P1 priority is reasonable IMO. And status could be "Available" instead of "Untriaged". But let's also get some feedback from other folks.
,
Nov 28 2017
Does P1 sound good to you for bugs filed for newly-added flaky tests like above?
,
Nov 28 2017
,
Nov 28 2017
Yes.
,
Nov 28 2017
This is what I'm thinking for buckets: P1 95-100% P2 90-95% P3 <90% Any input on this? Otherwise I'll add this today.
,
Nov 28 2017
Could you clarify what those percentages mean? Folks might not know. I would not do too fine-grained bucketing for now. Ideally, we could have only two buckets to file bugs: * extremely reliable: no to little need of manual verification, could take action immediately -- revert/disable/fix/etc * very likely: some amount of manual verification, but finding is actionable. For none-actionable findings, I would not file bugs for them.
,
Nov 28 2017
My previous comment contains percentages. Those represent the confidence Findit has in the findings (0-1). 1 being a newly added test. If we don't want to bucket them too severely, then I'll say >.98 is a P1. Anything below that is a P3. I think we'll find everything over 95% confidence is pretty helpful, but we can start here.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d46e115c5f828447e5884b1e88a26b654bf41504 commit d46e115c5f828447e5884b1e88a26b654bf41504 Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Nov 29 00:33:13 2017 [Findit] Flake Analyzer - Give filed bugs priority and a status When Findit files a bug, it doesn't assign a priority. I fixed this so that now a priority is set. This will fix ths issue where it wouldn't surface correctly in SoM. Right now the status is Unconfirmed, but this should actually be available. Bug: 789250 Change-Id: I0dc23c939c7a156f921e5341b595f12168e8fc8a Reviewed-on: https://chromium-review.googlesource.com/794375 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> [modify] https://crrev.com/d46e115c5f828447e5884b1e88a26b654bf41504/appengine/findit/services/flake_failure/issue_tracking_service.py [modify] https://crrev.com/d46e115c5f828447e5884b1e88a26b654bf41504/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py [modify] https://crrev.com/d46e115c5f828447e5884b1e88a26b654bf41504/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py [modify] https://crrev.com/d46e115c5f828447e5884b1e88a26b654bf41504/appengine/findit/services/flake_failure/test/issue_tracking_service_test.py
,
Nov 29 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by st...@chromium.org
, Nov 28 2017