[Canvas] Make low latency mode work with GPU acceleration |
|||||||
Issue descriptionThe initial implementation of low latency mode does not work with GPU acceleration. For now, HTMLCanvasElement::shouldAccelerate() returns false when in low latency mode. The reason GPU-acceleration does not work is currently unknown.
,
Jul 25
,
Jul 25
,
Jul 25
,
Jul 25
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fff44ec70ab202add6f06e6f8603637d265ccc4 commit 1fff44ec70ab202add6f06e6f8603637d265ccc4 Author: Justin Novosad <junov@chromium.org> Date: Wed Jul 25 20:48:09 2018 Make 2D canvases in low latency mode use GPU This change removes code that indicated a preference for software rendering when a 2D canvas was in low latency mode BUG= 789232 Change-Id: If2c22cb68db63b9dcc9a7170960fc6414703fe40 Reviewed-on: https://chromium-review.googlesource.com/1150577 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578049} [modify] https://crrev.com/1fff44ec70ab202add6f06e6f8603637d265ccc4/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
,
Jul 25
The previous CL did not do the whole job. A follow-up CL is in flight to turn on GPU-acceleration for real.
,
Jul 25
#7 and that'll be crrev.com/c/1150721 :-)
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7eb1a6cc55d29d9709e7799529996e9902d769d1 commit 7eb1a6cc55d29d9709e7799529996e9902d769d1 Author: Justin Novosad <junov@chromium.org> Date: Thu Jul 26 15:58:34 2018 Gpu accelerate low latency 2d canvas for real This is a follow-up to CL: https://chromium.googlesource.com/chromium/src/+/1fff44ec70ab202add6f06e6f8603637d265ccc4 BUG= 789232 Change-Id: I703333249b0c06642647842b2c735424b795447f Reviewed-on: https://chromium-review.googlesource.com/1150721 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578316} [modify] https://crrev.com/7eb1a6cc55d29d9709e7799529996e9902d769d1/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
,
Jul 26
,
Jul 26
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ed6bfad505bd90fbe1f29fd11ccd362ce128d1f commit 9ed6bfad505bd90fbe1f29fd11ccd362ce128d1f Author: Justin Novosad <junov@chromium.org> Date: Thu Jul 26 23:07:36 2018 Fix DCHECK crash with gpu-accelerated low latency 2d canvas BUG= 789232 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic142b7099f0a813764e750b23236822b53f894fa Reviewed-on: https://chromium-review.googlesource.com/1151906 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#578475} [modify] https://crrev.com/9ed6bfad505bd90fbe1f29fd11ccd362ce128d1f/third_party/blink/renderer/core/html/canvas/html_canvas_element.h [modify] https://crrev.com/9ed6bfad505bd90fbe1f29fd11ccd362ce128d1f/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc [modify] https://crrev.com/9ed6bfad505bd90fbe1f29fd11ccd362ce128d1f/third_party/blink/renderer/platform/graphics/canvas_resource_host.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mcasas@chromium.org
, Jul 24