New issue
Advanced search Search tips

Issue 789225 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: flaky test http/tests/devtools/console/console-focus.js

Project Member Reported by chenwilliam@chromium.org, Nov 28 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235cb69fb2489ed6f4decfd246084f89cf90528e

commit 235cb69fb2489ed6f4decfd246084f89cf90528e
Author: Will Chen <chenwilliam@chromium.org>
Date: Tue Nov 28 20:13:25 2017

DevTools: mark test as flaky http/tests/devtools/console-focus.js

TBR=luoe@chromium.org

Bug:  789225 
Change-Id: I1453c23aa6ccd1c5db9b96423e8e5d9061bc412f
Reviewed-on: https://chromium-review.googlesource.com/794393
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519812}
[modify] https://crrev.com/235cb69fb2489ed6f4decfd246084f89cf90528e/third_party/WebKit/LayoutTests/TestExpectations

Status: WontFix (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df24ae6906f83b6b3b7c5eda48b20710b246d5de

commit df24ae6906f83b6b3b7c5eda48b20710b246d5de
Author: Erik Luo <luoe@chromium.org>
Date: Fri Feb 02 06:46:26 2018

DevTools: unflake console-focus.js test

This test was flaky because it logged console messages but did not
wait for the viewport to render their elements in DOM. This CL
unflakes the test by waiting for pending viewport refreshes.

Bug:  789225 
Change-Id: I9861b067df72c66b00021050cf07562b0064f66c
Reviewed-on: https://chromium-review.googlesource.com/898389
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533981}
[modify] https://crrev.com/df24ae6906f83b6b3b7c5eda48b20710b246d5de/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/df24ae6906f83b6b3b7c5eda48b20710b246d5de/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-focus.js
[modify] https://crrev.com/df24ae6906f83b6b3b7c5eda48b20710b246d5de/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/df24ae6906f83b6b3b7c5eda48b20710b246d5de/third_party/WebKit/Source/devtools/front_end/console_test_runner/ConsoleTestRunner.js

Sign in to add a comment