Came up in review here: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/788187/1/base/rand_util.cc#121 But there's a decent number of zx_status_get_string() calls https://cs.chromium.org/search/?q=zx_status_get_string&sq=package:chromium&type=cs in Chromium that could more tersely expressed with a simple macro, so we should add a ZX_LOG family. Unfortunately, I don't think it be PLOG because the zx_status_t is returned, rather than being stored as a TLS errno/GetLastError() type of value.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d90951b3aea3f95bb6e8fcba7b1045dc37739533 commit d90951b3aea3f95bb6e8fcba7b1045dc37739533 Author: Scott Graham <scottmg@chromium.org> Date: Tue Nov 28 23:53:26 2017 fuchsia: Add ZX_LOG and friends Bug: 789213 Change-Id: I26ff91e89a49fdb63759fdcdbe5e46bdb413a425 Reviewed-on: https://chromium-review.googlesource.com/794347 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#519909} [modify] https://crrev.com/d90951b3aea3f95bb6e8fcba7b1045dc37739533/base/BUILD.gn [add] https://crrev.com/d90951b3aea3f95bb6e8fcba7b1045dc37739533/base/fuchsia/fuchsia_logging.cc [add] https://crrev.com/d90951b3aea3f95bb6e8fcba7b1045dc37739533/base/fuchsia/fuchsia_logging.h [modify] https://crrev.com/d90951b3aea3f95bb6e8fcba7b1045dc37739533/base/logging_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/mini_chromium/+/f609089390cd700d00fcc8492209c75525070a34 commit f609089390cd700d00fcc8492209c75525070a34 Author: Scott Graham <scottmg@chromium.org> Date: Fri Dec 01 01:24:00 2017 fuchsia: Add ZX_LOG, et al. to mini_chromium Similar to implementation added in https://chromium-review.googlesource.com/794347 tweaked for mini_chromium's differing LogMessage prototype. Fix rand_util to use ZX_CHECK instead of CHECK without zx_status_t printing. Bug: 789213 , crashpad:196 Change-Id: I32f582f4b2375244f262adfbb478e78d43c4de81 Reviewed-on: https://chromium-review.googlesource.com/802454 Reviewed-by: Mark Mentovai <mark@chromium.org> [add] https://crrev.com/f609089390cd700d00fcc8492209c75525070a34/base/fuchsia/fuchsia_logging.cc [add] https://crrev.com/f609089390cd700d00fcc8492209c75525070a34/base/fuchsia/fuchsia_logging.h [modify] https://crrev.com/f609089390cd700d00fcc8492209c75525070a34/base/BUILD.gn [modify] https://crrev.com/f609089390cd700d00fcc8492209c75525070a34/base/rand_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/635d061df32dfe00ff4d9a50f03f9a650616efcf commit 635d061df32dfe00ff4d9a50f03f9a650616efcf Author: Scott Graham <scottmg@chromium.org> Date: Wed Jan 17 23:07:28 2018 fuchsia: Some logging tweaks per suggestions Follow ups from comments in https://chromium-review.googlesource.com/c/chromium/src/+/794347/. Also add pointer OWNERS to base/fuchsia. Bug: 789213 Change-Id: I046a21f9805410a54fd3b6e8f08801e1c8ab9a4a Reviewed-on: https://chromium-review.googlesource.com/871411 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#529939} [add] https://crrev.com/635d061df32dfe00ff4d9a50f03f9a650616efcf/base/fuchsia/OWNERS [modify] https://crrev.com/635d061df32dfe00ff4d9a50f03f9a650616efcf/base/fuchsia/fuchsia_logging.h [modify] https://crrev.com/635d061df32dfe00ff4d9a50f03f9a650616efcf/base/fuchsia/scoped_zx_handle.h
Comment 1 by mark@chromium.org
, Nov 28 2017