Issue metadata
Sign in to add a comment
|
Select-to-Speak should not try to draw a highlight on staticText nodes as boundsForRange doesn't work on them |
||||||||||||||||||||||||
Issue descriptionNot sure why boundsForRange doesn't work on staticText with no children... but meanwhile it doesn't make sense to draw a highlight on these nodes.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98c5a82f46013599fae795d823f59b24d472cd2f commit 98c5a82f46013599fae795d823f59b24d472cd2f Author: Katie Dektar <katydek@google.com> Date: Wed Nov 29 00:27:42 2017 Select to Speak should not highlight staticText nodes. staticText nodes will not work with the boundsForRange function so it doesn't make sense to try to highlight them. Bug: 789211 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I958bb75e663f5cf2b073466014e7122899b892bf Reviewed-on: https://chromium-review.googlesource.com/794517 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie D <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#519924} [modify] https://crrev.com/98c5a82f46013599fae795d823f59b24d472cd2f/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
,
Nov 29 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by katie@chromium.org
, Nov 28 2017