Editing CL description causes try jobs to stop running |
|||||
Issue descriptionBecause try jobs take a while to run I will start them up as soon as I have created a CL. I will then spend time honing the rhetoric of my description to Shakespearean levels of perfection. However when I save my updated description this cancels my try jobs. This can be seen here: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/794298/1 The output is: Tue Nov 28 2017 10:31:49 GMT-0800 (Pacific Standard Time)(2 minutes) CQ stopped processing patch Tue Nov 28 2017 10:31:49 GMT-0800 (Pacific Standard Time)(2 minutes) CQ rejected the patch (CQ bit was unchecked.) This is quite confusing. The first dozen times this happened I didn't notice which meant that my try jobs were delayed until I restarted them hours later. Now I know that this will happen so I avoid editing my description (what a shame) or I restart my try jobs immediately after (seems wasteful). Try jobs should not be affected by changes to the description.
,
Nov 29 2017
There are two related issues which should be considered as well to make sure we get exactly the behavior we want: 1) Editing the description causes runs of the CQ to be cancelled, which is probably also undesirable? 2) Editing the description after approvals were granted causes warnings about post-approval-changes These are both changes from Rietveld and they are *probably* not what we want, but I can see a case being made for them being correct, maybe, so I wanted to explicitly point them out. Thanks for looking at this.
,
Nov 29 2017
,
Nov 29 2017
Yep, we're aware of both of those, and they're conscious decisions. 1) As long as the CQ+1/2 vote is still there, the CQ will immediately start a new run, and re-use jobs from the previous run. So it doesn't add load, and it lets the CQ ensure that it is using the correct CQ_INCLUDE_TRYBOTS parameters if they changed in the commit message. 2) The post-approval-changes warning includes the name of the patchset, which is "Edit commit message" for in-UI edits. We'd like to be able to filter these, but can't without a ton of work on the Gerrit team's side, so we've let this one sit as a low priority desire.
,
Nov 30 2017
chromium/src config change: https://chromium.googlesource.com/chromium/src/+/5a491b195f48c314705966448c515e77a6bd9f93
,
Dec 4 2017
Is the config change mentioned in comment#5 supposed to resolve this issue? I'm still seeing the same behavior.
,
Dec 5 2017
Same here, at least as late as yesterday.
,
Dec 5 2017
What repo? chromium/src?..
,
Dec 5 2017
Yes. One example is https://chromium-review.googlesource.com/c/chromium/src/+/806217 where I uploaded it 15:19. Twenty minutes later I noticed that the tryjobs hadn't started and I started them manually from the web page.
,
Dec 5 2017
Hm, it should have copied Commit-Queue label into the new patchset per https://chromium.googlesource.com/chromium/src/+/refs/meta/config/project.config#14 Not sure why it didn't work...
,
Dec 5 2017
Filed https://bugs.chromium.org/p/gerrit/issues/detail?id=7929 to follow up on that.
,
Jan 3 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by aga...@chromium.org
, Nov 29 2017Status: Available (was: Untriaged)