New issue
Advanced search Search tips

Issue 789197 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make waveshaper test outputs be more descriptive

Project Member Reported by rtoy@chromium.org, Nov 28 2017

Issue description

The output of waveshaper-simple.html is:

This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [simple] 
PASS   WaveShaper.curve is equal to null.
PASS   WaveShaper.oversample is equal to none.
PASS   Waveshaper.oversample = "2x" is equal to 2x.
PASS   Waveshaper.oversample = "4x" is equal to 4x.
PASS   Waveshaper.oversample = "invalid" is equal to 4x.
PASS   WaveShaper.curve is identical to the array [-1,0.25,0.75].
PASS   Waveshaper.curve = null is equal to null.
PASS < [simple] All assertions passed. (total 7 assertions)
PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.
Harness: the test ran to completion.

It's kind of hard to tell what all of this means.  It would be nice if
the test were a bit more verbose on what is happening so you can just
look at the output and get a sense of the actual tests being done.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f7f418b3d3211dd99b1c418a7011b78c7df5305

commit 7f7f418b3d3211dd99b1c418a7011b78c7df5305
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Nov 28 23:20:08 2017

Make WaveShaper test output more self-explanatory

When reading the output of the waveshaper tests, it's kind of hard to
tell exactly what's being tested.  Add a few more test messages and/or
labels to make it a bit clearer.

Bug:  789197 
Test: WaveShaper/waveshaper-{copy-curve,simple}.html
Change-Id: Ic90ebe94282d4b416321766bc16daa3cbc53299c
Reviewed-on: https://chromium-review.googlesource.com/794018
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519891}
[modify] https://crrev.com/7f7f418b3d3211dd99b1c418a7011b78c7df5305/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-copy-curve.html
[modify] https://crrev.com/7f7f418b3d3211dd99b1c418a7011b78c7df5305/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-simple.html

Comment 2 by rtoy@chromium.org, Nov 29 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment