New issue
Advanced search Search tips

Issue 789192 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 804191



Sign in to add a comment

performance_browser_tests failing on multiple builders (CastV2PerformanceTest disabled)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 28 2017

Issue description

performance_browser_tests failing on multiple builders

Builders failed on: 
- Win 7 ATI GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf
- Win 7 Intel GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf


 
Test "CastV2PerformanceTest.Performance/0" is timing out.
 Issue 788789  has been merged into this issue.
Owner: m...@chromium.org
Status: Assigned (was: Available)
Disabling the test and assigning to benchmark owner.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/139c5de3152705f3fde97047080efdcae36aa706

commit 139c5de3152705f3fde97047080efdcae36aa706
Author: Alexander Timin <altimin@chromium.org>
Date: Tue Nov 28 18:31:34 2017

[perf bot sheriff] Disable CastV2PerformanceTestPerformance on Win.

TBR=miu@chromium.org

BUG= 789192 

Change-Id: Iac44a0facb28d55b744ce11c1de9add0cf0944a0
Reviewed-on: https://chromium-review.googlesource.com/794271
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519759}
[modify] https://crrev.com/139c5de3152705f3fde97047080efdcae36aa706/chrome/browser/extensions/api/cast_streaming/performance_test.cc

Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Nov 28 2017


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : performance_browser_tests
  Metric       : CastV2Performance_gpu_24fps/audio_jitter

Revision             Exit Code      N
chromium@519069      0 +- N/A       20      good
chromium@519096      0 +- N/A       20      bad

To Run This Test
  .\src\out\Release_x64\performance_browser_tests.exe --test-launcher-print-test-stdio=always --enable-gpu

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961660081234676272


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Nov 28 2017


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : performance_browser_tests
  Metric       : CastV2Performance_gpu_24fps/audio_jitter

Revision             Exit Code      N
chromium@518110      0 +- N/A       20      good
chromium@518211      0 +- N/A       20      bad

To Run This Test
  .\src\out\Release_x64\performance_browser_tests.exe --test-launcher-print-test-stdio=always --enable-gpu

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961660121830988672


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 28 2017


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: win_x64_perf_bisect
  Benchmark    : performance_browser_tests
  Metric       : CastV2Performance_gpu_24fps/resolution_changes

Revision             Exit Code      N
chromium@518934      0 +- N/A       20      good
chromium@519007      0 +- N/A       20      bad

To Run This Test
  .\src\out\Release_x64\performance_browser_tests.exe --test-launcher-print-test-stdio=always --enable-gpu

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961660031136011728


For feedback, file a bug with component Speed>Bisection
Labels: -Sheriff-Chromium
Test disabled and owner assigned -> taking out of sheriff queue

Comment 12 by m...@chromium.org, Jan 25 2018

Labels: -Pri-2 M-66 Pri-1
Summary: performance_browser_tests failing on multiple builders (CastV2PerformanceTest disabled) (was: performance_browser_tests failing on multiple builders)

Comment 13 by m...@chromium.org, Jan 25 2018

Cc: hoegsberg@google.com m...@chromium.org
 Issue 735679  has been merged into this issue.

Comment 14 by m...@chromium.org, Feb 1 2018

Components: Internals>Media>Capture

Comment 15 by m...@chromium.org, Feb 7 2018

Components: Internals>Media>ScreenCapture

Comment 16 by m...@chromium.org, Feb 7 2018

Components: -Internals>Media>Capture

Comment 17 by m...@chromium.org, Feb 7 2018

Blockedon: 804191

Comment 18 by m...@chromium.org, Feb 14 2018

Labels: -Pri-1 -M-66 M-67 Pri-2
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9cee7e5db8b778279bf39c3a249ab1140616b83

commit c9cee7e5db8b778279bf39c3a249ab1140616b83
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Oct 30 21:46:17 2018

Get performance_browser_tests working again.

Fixes:

1. The timestamp field in the event traces has been made consistent
(between the Capture and OnBufferReceived trace events). This allows
pipeline tracking of individual frames (and fixes the 97-100% drop rate
bug).

2. Add BUILD.gn target dependencies to build browser PAK/resources that
are required in order to run the binary.

3. Allow thread-blocking in media::cast::test::UDPProxyImpl.

Bug:  789192 ,  816466 ,  806238 
Change-Id: If606989e8ea5eea34fd25e58246ecb7dd9cb75d1
Reviewed-on: https://chromium-review.googlesource.com/c/1308103
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604023}
[modify] https://crrev.com/c9cee7e5db8b778279bf39c3a249ab1140616b83/chrome/browser/extensions/api/cast_streaming/performance_test.cc
[modify] https://crrev.com/c9cee7e5db8b778279bf39c3a249ab1140616b83/chrome/test/BUILD.gn
[modify] https://crrev.com/c9cee7e5db8b778279bf39c3a249ab1140616b83/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc
[modify] https://crrev.com/c9cee7e5db8b778279bf39c3a249ab1140616b83/media/cast/test/utility/udp_proxy.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a787e356d95756d1d4173493461dd58201857e4

commit 5a787e356d95756d1d4173493461dd58201857e4
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Nov 14 04:14:43 2018

Re-enable performance_browser_tests on all platforms.

Fixes were made to restore the functioning of the tests in commit
c9cee7e5db8b778279bf39c3a249ab1140616b83.

Bug:  789192 
Change-Id: I3ec2b8a2dd3a04f24dbcc3998ca3f7f138cc281f
Reviewed-on: https://chromium-review.googlesource.com/c/1334852
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#607898}
[modify] https://crrev.com/5a787e356d95756d1d4173493461dd58201857e4/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/5a787e356d95756d1d4173493461dd58201857e4/tools/perf/core/perf_data_generator.py

Status: Fixed (was: Assigned)

Sign in to add a comment