New issue
Advanced search Search tips

Issue 789184 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 781419
issue 781428



Sign in to add a comment

[root layer scrolls] devtools/tracing/timeline-paint test failures

Project Member Reported by pdr@chromium.org, Nov 28 2017

Issue description

The following tests fail with root layer scrolling enabled:
http/tests/devtools/tracing/timeline-paint/layer-tree.js
http/tests/devtools/tracing/timeline-paint/paint-profiler-update.js
http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.js
http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.js
http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations.js
http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.js
http/tests/devtools/tracing/timeline-paint/timeline-paint.js

The basic idea of invalidation tracking is that trace events (e.g., the devtools.timeline.invalidationTracking trace event in Node::SetNeedsStyleRecalc) are recorded for all invalidations and paints. These events are then connected together in devtools/front_end/timeline_model/TimelineModel.js. For example, a style recalc event that precedes a paint will be considered an invalidating event for that paint.

There is an issue with the LayoutView with root layer scrolling enabled because invalidations are issued with the LayoutView id but the paints occur with the scrolling contents layer id and we do not correctly associate the invalidations with the resulting paint.

I think we may have a similar bug with all composited overflow scroll areas. I wasn't able to see where this is broken in the devtools UI so this may not be user-visible.
 

Comment 1 by pdr@chromium.org, Dec 2 2017

Blocking: 781428

Comment 2 by bokan@chromium.org, Mar 1 2018

Owner: bokan@chromium.org
Status: Assigned (was: Available)
The remaining lines in TestExpectations all pass unexpectedly for me when run locally. Looking at flakiness dashboard they appear to pass on bots as well so I'll just remove the expectations.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c58485d7150404d28e55f8c2bac13dfa57100af

commit 8c58485d7150404d28e55f8c2bac13dfa57100af
Author: David Bokan <bokan@chromium.org>
Date: Thu Mar 01 22:38:15 2018

Remove passing timeline-paint test expectations

All these tests pass locally and on the bots so removing.

Bug:  789184 
Change-Id: I5b04ccdee8c39837d0f31ead05f206b00069e59c
Reviewed-on: https://chromium-review.googlesource.com/944010
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540316}
[modify] https://crrev.com/8c58485d7150404d28e55f8c2bac13dfa57100af/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by pdr@chromium.org, Mar 1 2018

Status: Fixed (was: Assigned)
It looks like r538702 fixed this. :)

Sign in to add a comment