[root layer scrolls] devtools/tracing/timeline-paint test failures |
|||
Issue descriptionThe following tests fail with root layer scrolling enabled: http/tests/devtools/tracing/timeline-paint/layer-tree.js http/tests/devtools/tracing/timeline-paint/paint-profiler-update.js http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.js http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.js http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations.js http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.js http/tests/devtools/tracing/timeline-paint/timeline-paint.js The basic idea of invalidation tracking is that trace events (e.g., the devtools.timeline.invalidationTracking trace event in Node::SetNeedsStyleRecalc) are recorded for all invalidations and paints. These events are then connected together in devtools/front_end/timeline_model/TimelineModel.js. For example, a style recalc event that precedes a paint will be considered an invalidating event for that paint. There is an issue with the LayoutView with root layer scrolling enabled because invalidations are issued with the LayoutView id but the paints occur with the scrolling contents layer id and we do not correctly associate the invalidations with the resulting paint. I think we may have a similar bug with all composited overflow scroll areas. I wasn't able to see where this is broken in the devtools UI so this may not be user-visible.
,
Mar 1 2018
The remaining lines in TestExpectations all pass unexpectedly for me when run locally. Looking at flakiness dashboard they appear to pass on bots as well so I'll just remove the expectations.
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c58485d7150404d28e55f8c2bac13dfa57100af commit 8c58485d7150404d28e55f8c2bac13dfa57100af Author: David Bokan <bokan@chromium.org> Date: Thu Mar 01 22:38:15 2018 Remove passing timeline-paint test expectations All these tests pass locally and on the bots so removing. Bug: 789184 Change-Id: I5b04ccdee8c39837d0f31ead05f206b00069e59c Reviewed-on: https://chromium-review.googlesource.com/944010 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540316} [modify] https://crrev.com/8c58485d7150404d28e55f8c2bac13dfa57100af/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 1 2018
,
Mar 2 2018
It looks like r538702 fixed this. :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by pdr@chromium.org
, Dec 2 2017