New issue
Advanced search Search tips

Issue 789139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

live-edit-no-reveal.js flaky on WebKit Linux Trusty dbg

Project Member Reported by hbos@chromium.org, Nov 28 2017

Issue description

http/tests/devtools/sources/debugger/live-edit-no-reveal.js
virtual/mojo-loading/http/tests/devtools/sources/debugger/live-edit-no-reveal.js

Flaky on:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29

Here's one with both virtual and non-virtual failing:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/7384

First failure:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/7382
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aa38ec5c62d57931f701c1aaac3fccd50b221f2

commit 6aa38ec5c62d57931f701c1aaac3fccd50b221f2
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Nov 28 14:19:05 2017

Marked live-edit-no-reveal.js as flaky on Linux

TBR=eseckler@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  789139 
Change-Id: Ia2d504b3c5a26bcbf5468db6e1f0d06c99c38aef
Reviewed-on: https://chromium-review.googlesource.com/793511
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519674}
[modify] https://crrev.com/6aa38ec5c62d57931f701c1aaac3fccd50b221f2/third_party/WebKit/LayoutTests/TestExpectations

Owner: ----
Status: Available (was: Assigned)
dunno why this was assigned to me (?)
Cc: -devtools-dev@chromium.org
Owner: chenwilliam@chromium.org
Status: Assigned (was: Available)

Comment 4 by hbos@chromium.org, Nov 28 2017

#2: I looked at the owner file which was a comment for devtools-dev@chromium.org, not an actual user, and couldn't find a higher-level owner without going way up, but I found your name associated with a devtools-dev google groups, thinking maybe you work with the DevTools things.

#dgozman: Thanks for re-triaging.
Labels: -Pri-1 Pri-3
Owner: kozy@chromium.org
We should disable for now.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f421a8aab1a1257630f54850ff236ce9bfeca172

commit f421a8aab1a1257630f54850ff236ce9bfeca172
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jan 10 23:35:08 2018

Disable http/tests/devtools/sources/debugger/live-edit-no-reveal.js

Failing on multiple builders.

TBR=kozy@chromium.org

Bug:  789139 
Change-Id: Ic150cc7035a52d0a55ed4d55d3b28ba541696612
Reviewed-on: https://chromium-review.googlesource.com/861094
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528480}
[modify] https://crrev.com/f421a8aab1a1257630f54850ff236ce9bfeca172/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fcbf6597b312d0d6e2a725fb131b662efd35c75

commit 1fcbf6597b312d0d6e2a725fb131b662efd35c75
Author: erikchen <erikchen@chromium.org>
Date: Tue Nov 27 17:31:16 2018

Disable live-edit-no-reveal.js layout test.

The test was enabled here:
https://chromium-review.googlesource.com/c/chromium/src/+/1258249/

The test deterministically fails when run by itself. This failure is
reproducible on both trybots and a local device.

This CL reverts the change made by the CL mentioned above. It intentionally sets
a super broad set of TestExpectations as I have not investigated the behavior of
the test on platforms other than Windows. The test was observed to be flaky on
Linux -- this CL removes that TestExpectation. The test was observed by Find-It
to be flaky on macOS. See
https://bugs.chromium.org/p/chromium/issues/detail?id=908517#c3.

Bug:  908517 ,  789139 
Change-Id: Idfa9603b093c9abc4c337c33a4a3e061482d9dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1351491
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611167}
[modify] https://crrev.com/1fcbf6597b312d0d6e2a725fb131b662efd35c75/third_party/blink/web_tests/TestExpectations

Sign in to add a comment