Clean up after ThirdPartyDoodles launch |
|||||
Issue descriptionAfter ThirdPartyDoodles has rolled out to Stable with M63, assuming nothing exploded, we should get rid of the feature toggle. This means removing features::kThirdPartyDoodles. We should keep the about:flags entry so that it's still possible to force test doodles, but it should use the cmdline switch to override the URL instead of the feature param. As a semi-related followup, we should then also put Google's Doodle URL into prepopulated_engines.json and avoid a bit of special code in LogoServiceImpl.
,
Nov 28 2017
,
Jan 15 2018
The NextAction date has arrived: 2018-01-15
,
Jan 15 2018
,
Jan 15 2018
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/257bc3c35e39c34b713788b314b0c26edf8ab0a7 commit 257bc3c35e39c34b713788b314b0c26edf8ab0a7 Author: Marc Treib <treib@chromium.org> Date: Tue Jan 16 10:17:10 2018 Cleanup: Remove search_provider_logos::features::kThirdPartyDoodles This has rolled out to Stable without issues, let's get rid of the kill switch. Bug: 789135 Change-Id: I0c2919ddb0c7c5e89f34b950e036576c0cc24241 Reviewed-on: https://chromium-review.googlesource.com/867050 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#529392} [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/chrome/browser/about_flags.cc [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/chrome/browser/search_engines/template_url_service_android.cc [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/components/search_provider_logos/features.cc [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/components/search_provider_logos/features.h [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/components/search_provider_logos/logo_service_impl.cc [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/components/search_provider_logos/logo_service_impl_unittest.cc [modify] https://crrev.com/257bc3c35e39c34b713788b314b0c26edf8ab0a7/tools/metrics/histograms/enums.xml
,
Jan 16 2018
A pending CL for the followup (moving Google's doodle_url into prepopulated_engines.json) is at https://crrev.com/c/867950. But it doesn't work yet, because currently the "doodle_url" field doesn't support replacements, and we'd need {google:baseURL}.
,
Feb 1 2018
Calling this one done, since the possible follow-up cleanup is not really related. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by treib@chromium.org
, Nov 28 2017