[Dice] Display error dialog when signin to Sync fails |
|||||||
Issue descriptionAs part of Dice Milestone 2, the Sync signin flow is changing. It should implement an error dialog if the request for the refresh token fails. This feature exists in the old flow, and must be ported to the new flow.
,
Dec 4 2017
,
Dec 4 2017
Please add affected OSs.
,
Dec 5 2017
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f13c93d5eb3bc5e96df8d5877464245ea80a35f commit 7f13c93d5eb3bc5e96df8d5877464245ea80a35f Author: David Roger <droger@chromium.org> Date: Thu Dec 07 14:25:28 2017 [signin] Handle Dice token exchange failures When the Dice token exchange fails: - if this is a Sync signin, the tab is navigated to the NTP, to match the behavior of the success case - if this is a Sync signin or if Dice is fully enabled for this profile, display the signin error dialog. Bug: 789130 Change-Id: I4a5309a18301c4e3112db50296edd625682f0fd3 Reviewed-on: https://chromium-review.googlesource.com/810805 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#522416} [modify] https://crrev.com/7f13c93d5eb3bc5e96df8d5877464245ea80a35f/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/7f13c93d5eb3bc5e96df8d5877464245ea80a35f/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/7f13c93d5eb3bc5e96df8d5877464245ea80a35f/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/7f13c93d5eb3bc5e96df8d5877464245ea80a35f/chrome/browser/signin/process_dice_header_delegate_impl.cc [modify] https://crrev.com/7f13c93d5eb3bc5e96df8d5877464245ea80a35f/chrome/browser/signin/process_dice_header_delegate_impl.h
,
Dec 7 2017
,
Dec 8 2017
,
Dec 9 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/654464b690cc94bbf797be111ba8633396c3cf70 commit 654464b690cc94bbf797be111ba8633396c3cf70 Author: David Roger <droger@chromium.org> Date: Mon Dec 11 10:41:38 2017 [signin] Handle Dice token exchange failures When the Dice token exchange fails: - if this is a Sync signin, the tab is navigated to the NTP, to match the behavior of the success case - if this is a Sync signin or if Dice is fully enabled for this profile, display the signin error dialog. TBR=droger@chromium.org (cherry picked from commit 7f13c93d5eb3bc5e96df8d5877464245ea80a35f) Bug: 789130 Change-Id: I4a5309a18301c4e3112db50296edd625682f0fd3 Reviewed-on: https://chromium-review.googlesource.com/810805 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522416} Reviewed-on: https://chromium-review.googlesource.com/817776 Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#124} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/654464b690cc94bbf797be111ba8633396c3cf70/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/654464b690cc94bbf797be111ba8633396c3cf70/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/654464b690cc94bbf797be111ba8633396c3cf70/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/654464b690cc94bbf797be111ba8633396c3cf70/chrome/browser/signin/process_dice_header_delegate_impl.cc [modify] https://crrev.com/654464b690cc94bbf797be111ba8633396c3cf70/chrome/browser/signin/process_dice_header_delegate_impl.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msarda@chromium.org
, Nov 28 2017Owner: msarda@chromium.org
Status: Assigned (was: Available)