New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789125 link

Starred by 2 users
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Dec 2017
Cc:
█ xunji...@chromium.org
█ vm.ar...@samsung.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

P2PSocketDispatcherHost doesn't update network list when device goes offline

Project Member Reported by pauljensen@chromium.org, Nov 28 2017 
As of https://chromium-review.googlesource.com/c/chromium/src/+/754765 P2PSocketDispatcherHost doesn't update network list when device goes offline.  I would assume it should update the list when the device goes offline.  This was the prior behavior.

Comment 1 by guidou@chromium.org, Nov 28 2017

Cc: -sergeyu@chromium.org
Owner: sergeyu@chromium.org
Status: Assigned (was: Untriaged)
sergeyu@: Can you take a look/help triage?
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11126aa0dcf4bd13efb3d31f21fc1869a914b9e3

commit 11126aa0dcf4bd13efb3d31f21fc1869a914b9e3
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 15 19:14:26 2017

Handle offline event in P2PSocketDispatcherHost

P2PSocketDispatcherHost is supposed to update network list even
when the system is offline (i.e. after last NIC is brought down).

Bug:  789125 
Change-Id: Id732ca2e35f7ea435bc960fd37a2656b152fac32
Reviewed-on: https://chromium-review.googlesource.com/802237
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524425}
[modify] https://crrev.com/11126aa0dcf4bd13efb3d31f21fc1869a914b9e3/content/browser/renderer_host/p2p/socket_dispatcher_host.cc

Comment 3 by pauljensen@chromium.org, Dec 15 2017 

The original breaking CL went in before M64 was cut; should we merge fix to M64?

Comment 4 by sergeyu@chromium.org, Dec 15 2017 

I don't think it's worth merging it at this point since m64 branched 2 weeks ago. There should be no significant impact on the user.

Comment 5 by sergeyu@chromium.org, Dec 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment