Implementation of passwords export on iOS |
|||
Issue description
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b19089c9be79fd2a5e6fff09efbaf362bb96b872 commit b19089c9be79fd2a5e6fff09efbaf362bb96b872 Author: Ioana Pandele <ioanap@chromium.org> Date: Tue Dec 12 11:48:35 2017 Add button for exporting passwords in Settings > Save Passwords This button is behind a flag and doesn't currently do anything when tapped on. The rest of the functionality will be added in follow-up CLs. The button should be disabled whenever there are no saved passwords displayed. General design: https://docs.google.com/a/chromium.org/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit?usp=sharing Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I95bd4b3ad3b04a52e93488def7744e85d7172ffe Reviewed-on: https://chromium-review.googlesource.com/809424 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#523408} [modify] https://crrev.com/b19089c9be79fd2a5e6fff09efbaf362bb96b872/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/b19089c9be79fd2a5e6fff09efbaf362bb96b872/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/b19089c9be79fd2a5e6fff09efbaf362bb96b872/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/b19089c9be79fd2a5e6fff09efbaf362bb96b872/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cd939828854fc16200f46fd2f363625321599db commit 3cd939828854fc16200f46fd2f363625321599db Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Dec 13 18:15:58 2017 Change Save Passwords tests to be parametrized and toggle the export feature flag The parametrized tests are needed until the export feature will be fully enabled. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I27aa0ec4582913e61dc4116fa6e8fc96f625ad14 Reviewed-on: https://chromium-review.googlesource.com/822250 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#523823} [modify] https://crrev.com/3cd939828854fc16200f46fd2f363625321599db/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b48592c0ab3d6b0784db994939afaaa5c59c39be commit b48592c0ab3d6b0784db994939afaaa5c59c39be Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Dec 13 18:22:53 2017 Add confirmation for passwords export This alerts the user about exporting passwords and allows them to confirm the action or cancel it. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84af89eae3c5b7004d197826abf1a1f5eccc3bb6 Reviewed-on: https://chromium-review.googlesource.com/817418 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#523825} [modify] https://crrev.com/b48592c0ab3d6b0784db994939afaaa5c59c39be/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/b48592c0ab3d6b0784db994939afaaa5c59c39be/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c590501405b4a931e05784935a4dfa39ececd02 commit 1c590501405b4a931e05784935a4dfa39ececd02 Author: Ioana Pandele <ioanap@chromium.org> Date: Mon Jan 15 16:31:38 2018 Move export button under the passwords list The export passwords button from Settings > Save Passwords will be moved to the bottom of the view, after the Saved Passwords and Never Saved sections, to comply with the latest UI mocks. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie596c001847db7f7bdd5d48f0426d3d6f71e2b25 Reviewed-on: https://chromium-review.googlesource.com/861784 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#529295} [modify] https://crrev.com/1c590501405b4a931e05784935a4dfa39ececd02/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/1c590501405b4a931e05784935a4dfa39ececd02/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd1e4ee068ffd71f791a9006d44ff5e0984dd207 commit bd1e4ee068ffd71f791a9006d44ff5e0984dd207 Author: Ioana Pandele <ioanap@chromium.org> Date: Mon Jan 22 17:32:43 2018 Add re-authentication for password export The re-authentication mechanism used for password export is almost the same as for password showing and copying. When exporting passwords, previous successful authentications are ignored and the user is always asked to re-authenticate. Bug: 789122 , 800686 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I299ae9de8f8686e6c3fa5a38b30a85d2408324aa Reviewed-on: https://chromium-review.googlesource.com/870782 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#530902} [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm [add] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/password_exporter.h [add] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/password_exporter.mm [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/reauthentication_module.h [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/reauthentication_module.mm [add] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/reauthentication_module_for_testing.h [add] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/reauthentication_module_unittest.mm [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/reauthentication_protocol.h [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.h [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/bd1e4ee068ffd71f791a9006d44ff5e0984dd207/ios/chrome/test/app/password_test_util.mm
,
Jan 25 2018
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb6b3797457edb0a24f9512e4e66af6ec1d27e4d commit eb6b3797457edb0a24f9512e4e66af6ec1d27e4d Author: Ioana Pandele <ioanap@chromium.org> Date: Thu Jan 25 13:56:28 2018 Change string for export passwords alert The alert is displayed after the user taps on the Export passwords... button. Change the message to comply with the latest mocks. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I778f5000f16b18c62f42bea4307a62a91ab079fc Reviewed-on: https://chromium-review.googlesource.com/886363 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#531884} [modify] https://crrev.com/eb6b3797457edb0a24f9512e4e66af6ec1d27e4d/ios/chrome/app/strings/ios_strings.grd
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a27c5abe3a8600fe89968b5befebb458cff6a816 commit a27c5abe3a8600fe89968b5befebb458cff6a816 Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Jan 31 15:16:19 2018 Completion of the passwords export flow This CL adds: - Request for password serialization - Writing passwords to a temporary file - Handling of errors that can occur during writing - Presenting a UIActivityViewController with options to save the file Bug:789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2963b9b425b5e6de62f0461c2d66cc19b2d61f22 Reviewed-on: https://chromium-review.googlesource.com/842623 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#533275} [modify] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/password_exporter.h [modify] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/password_exporter.mm [add] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/password_exporter_for_testing.h [add] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/password_exporter_unittest.mm [modify] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.h [modify] https://crrev.com/a27c5abe3a8600fe89968b5befebb458cff6a816/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3180cc44509cf5cc32c45aebbf0a97db3d2f8fe3 commit 3180cc44509cf5cc32c45aebbf0a97db3d2f8fe3 Author: Ioana Pandele <ioanap@chromium.org> Date: Fri Feb 02 14:18:09 2018 Remove usage of self from 2 different threads Bug:789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id0417fb700bc955013ca8ab3a1ad2ff7ce82ed54 Reviewed-on: https://chromium-review.googlesource.com/898986 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#534045} [modify] https://crrev.com/3180cc44509cf5cc32c45aebbf0a97db3d2f8fe3/ios/chrome/browser/ui/settings/password_exporter.mm
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/082af3c7ea9db50f0ced42277e5bbd22b5f0caa2 commit 082af3c7ea9db50f0ced42277e5bbd22b5f0caa2 Author: Ioana Pandele <ioanap@chromium.org> Date: Fri Feb 02 14:45:41 2018 Add progress indicator for password export This is an alert with the title "Preparing passwords..." displayed after the reauthentication step is finished, and while passwords are being serialized and written to the temporary file. The alert offers the user the option to cancel the exporting operation. If the user cancels, the exporter will wait for the async tasks to finish, perform necessary clean-up and then become available again. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8dd6b9a094e055eef15f5580e3d887e5cf979408 Reviewed-on: https://chromium-review.googlesource.com/897607 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#534046} [modify] https://crrev.com/082af3c7ea9db50f0ced42277e5bbd22b5f0caa2/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/082af3c7ea9db50f0ced42277e5bbd22b5f0caa2/ios/chrome/browser/ui/settings/password_exporter.h [modify] https://crrev.com/082af3c7ea9db50f0ced42277e5bbd22b5f0caa2/ios/chrome/browser/ui/settings/password_exporter.mm [modify] https://crrev.com/082af3c7ea9db50f0ced42277e5bbd22b5f0caa2/ios/chrome/browser/ui/settings/password_exporter_unittest.mm [modify] https://crrev.com/082af3c7ea9db50f0ced42277e5bbd22b5f0caa2/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b584a641f4c4146964b5477cb098b4b3f99094c5 commit b584a641f4c4146964b5477cb098b4b3f99094c5 Author: Ioana Pandele <ioanap@chromium.org> Date: Fri Feb 02 16:07:09 2018 Enable password export on iOS Bug:790982, 789122 Change-Id: I06bc82f7fb2f8f2451baeda178ea829d70aab100 Reviewed-on: https://chromium-review.googlesource.com/899007 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534065} [modify] https://crrev.com/b584a641f4c4146964b5477cb098b4b3f99094c5/components/password_manager/core/common/password_manager_features.cc
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5332e622613880c1e05e1f43d99af5f9a9a546ab commit 5332e622613880c1e05e1f43d99af5f9a9a546ab Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Feb 28 10:20:53 2018 Add metrics for password export on iOS (part 1) This CL adds the following metrics: - PasswordManager.ExportPasswordsToCSVResult - PasswordManager.TimeReadingExportedPasswords Metrics still to be added in following CLs: - PasswordManager.ExportedPasswordsPerUserInCSV Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5e92c93f07888e0e3fc7c7468de5543755e6834d Reviewed-on: https://chromium-review.googlesource.com/912131 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539777} [modify] https://crrev.com/5332e622613880c1e05e1f43d99af5f9a9a546ab/ios/chrome/browser/ui/settings/password_exporter.mm [modify] https://crrev.com/5332e622613880c1e05e1f43d99af5f9a9a546ab/ios/chrome/browser/ui/settings/password_exporter_unittest.mm [modify] https://crrev.com/5332e622613880c1e05e1f43d99af5f9a9a546ab/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e765c41d5fdca169942d6c5f80fc7995dd271841 commit e765c41d5fdca169942d6c5f80fc7995dd271841 Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Feb 28 15:11:00 2018 Add metrics for password export on iOS (part 2) This adds the remaining metric: - PasswordManager.ExportedPasswordsPerUserInCSV Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I913bedb9f3e716db6f7ac78975344f994ae02016 Reviewed-on: https://chromium-review.googlesource.com/939166 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539825} [modify] https://crrev.com/e765c41d5fdca169942d6c5f80fc7995dd271841/ios/chrome/browser/ui/settings/password_exporter.mm [modify] https://crrev.com/e765c41d5fdca169942d6c5f80fc7995dd271841/ios/chrome/browser/ui/settings/password_exporter_unittest.mm
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c145105dccd0721b7e11ce51fbe7be6d36763a31 commit c145105dccd0721b7e11ce51fbe7be6d36763a31 Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Feb 28 16:36:56 2018 Don't update export button if export flag is disabled This CL fixes a bug that causes a crash when the export feature is disabled. Bug: 789122 , 814574 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I19bca436ff86cb93b7b2fea786e8e4dfcb9dd4b9 Reviewed-on: https://chromium-review.googlesource.com/941123 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#539848} [modify] https://crrev.com/c145105dccd0721b7e11ce51fbe7be6d36763a31/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54fc48d4f9fb3566868d1bf087a14d8ee5701cb5 commit 54fc48d4f9fb3566868d1bf087a14d8ee5701cb5 Author: Ioana Pandele <ioanap@chromium.org> Date: Wed Feb 28 19:44:57 2018 Change the title of the Save Passwords Settings page to Passwords Since the Settings > Save Passwords view will contain a button for password export as well, it should be renamed to the more general "Passwords". Bug:789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2ea88a88a7bfa989384cb302681bc37649d5aa72 Reviewed-on: https://chromium-review.googlesource.com/911798 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Menglu Huang <huangml@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#539932} [modify] https://crrev.com/54fc48d4f9fb3566868d1bf087a14d8ee5701cb5/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/54fc48d4f9fb3566868d1bf087a14d8ee5701cb5/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/54fc48d4f9fb3566868d1bf087a14d8ee5701cb5/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/54fc48d4f9fb3566868d1bf087a14d8ee5701cb5/ios/chrome/test/earl_grey/chrome_matchers.mm
,
Mar 21 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Nov 28 2017