Make install attributes consistent among browser and fake_cryptohome_client in tests |
||||
Issue descriptionThere are several approaches for setting install attributes in tests now: 1. ScopedStubInstallAttributes which does not write attributes into the file. 2. Writing InstallAttributes::GetEnterpriseOwnedInstallAttributesBlobForTesting in the file. This one is wrong because strings are not wrote without 0 at the end. 3. Use cryptohome_util which caches attributes in fake_cryptohome_client. It could also write it on disk. The 3rd method sounds more reasonable to me. It's consistent between browser and dbus fake clients.
,
Nov 28 2017
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fed6482eeff38130f4858cd31307682282e0a142 commit fed6482eeff38130f4858cd31307682282e0a142 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Nov 29 11:43:48 2017 Add AuthPolicyLoginHelper::LockDeviceActiveDirectoryForTesting The function sets install attributes for Active Directory managed devices. Changes Active Directory tests to use that function. That way install attributes consistent between browser and D-Bus fake clients. BUG=chromium:789120, chromium:684679 Change-Id: Ic441c7ecc74b5abd06b346157aa044e457fd66c2 Reviewed-on: https://chromium-review.googlesource.com/793170 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#520076} [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chrome/browser/chromeos/settings/install_attributes.cc [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chrome/browser/chromeos/settings/install_attributes.h [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chromeos/dbus/fake_auth_policy_client_unittest.cc [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chromeos/login/auth/authpolicy_login_helper.cc [modify] https://crrev.com/fed6482eeff38130f4858cd31307682282e0a142/chromeos/login/auth/authpolicy_login_helper.h
,
Nov 29 2017
,
Dec 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rsorokin@chromium.org
, Nov 28 2017