New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789099 link

Starred by 1 user
Status: Started
Owner:
█ jose.dap...@lge.com
Last visit > 30 days ago
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task
Team-Accessibility

Blocking:
issue 784583



Sign in to add a comment

Add unit tests to AXPlatformNodeAuraLinux

Project Member Reported by jose.dap...@lge.com, Nov 28 2017 
Now the ATK code is completely isolated in ui/accessibility/platform, and duplication is gone, let's add unit tests.

The functionality should be equivalent to the one available for Windows unit tests for AXPlatformNodeWin. To do that, it is specially interesting to first move to a common class the platform independent code of AXPlatformNodeWinTest.

Comment 1 by jose.dap...@lge.com, Nov 28 2017

Cc: dmazz...@chromium.org

Comment 2 by jose.dap...@lge.com, Nov 28 2017

Blocking: 784583
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65405e7a8d9aaecf9081aca028c35ee66611075

commit e65405e7a8d9aaecf9081aca028c35ee66611075
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Tue Nov 28 22:37:48 2017

A11y: refactor AXPlatformNodeWin unit test platform independent code.

Move AXPlatformNodeWinTest utility methods that are platform independent
to a parent class that can be used for other platforms unit tests.

This is a preparation change to land later AXPlatformNodeAuraLinux unit
tests.

Bug: 789099
Change-Id: Ib0592dd96414ee3ad222c04e17d12537fc629fd8
Reviewed-on: https://chromium-review.googlesource.com/793034
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#519873}
[modify] https://crrev.com/e65405e7a8d9aaecf9081aca028c35ee66611075/ui/accessibility/BUILD.gn
[add] https://crrev.com/e65405e7a8d9aaecf9081aca028c35ee66611075/ui/accessibility/platform/ax_platform_node_unittest.cc
[add] https://crrev.com/e65405e7a8d9aaecf9081aca028c35ee66611075/ui/accessibility/platform/ax_platform_node_unittest.h
[modify] https://crrev.com/e65405e7a8d9aaecf9081aca028c35ee66611075/ui/accessibility/platform/ax_platform_node_win_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f22dc403403a8eb37d011f2fc64dd53d4c023d1

commit 9f22dc403403a8eb37d011f2fc64dd53d4c023d1
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Thu Nov 30 10:11:38 2017

A11y: add AXPlatformNodeAuraLinux unit tests

This commit adds unit tests for AtkObject, AtkComponent,
AtkHyperlinkImpl and AtkValue, based on several tests
also available on Windows backend.

Bug: 789099,  789060 
Change-Id: I8fd683141c1c5693fa3d5b80ecc3489cc8e9ebd8
Reviewed-on: https://chromium-review.googlesource.com/794139
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#520500}
[modify] https://crrev.com/9f22dc403403a8eb37d011f2fc64dd53d4c023d1/ui/accessibility/BUILD.gn
[modify] https://crrev.com/9f22dc403403a8eb37d011f2fc64dd53d4c023d1/ui/accessibility/platform/atk_util_auralinux.cc
[modify] https://crrev.com/9f22dc403403a8eb37d011f2fc64dd53d4c023d1/ui/accessibility/platform/atk_util_auralinux.h
[add] https://crrev.com/9f22dc403403a8eb37d011f2fc64dd53d4c023d1/ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc

Comment 5 by jose.dap...@lge.com, Nov 30 2017

Status: Started (was: Untriaged)
►

Sign in to add a comment