New issue
Advanced search Search tips

Issue 789096 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated fails in Win Clang and ASAN for official.desktop builder

Project Member Reported by brajkumar@chromium.org, Nov 28 2017

Issue description

Below mentioned content_unittest is flaky in Win Clang and Win64 Clang builds for official.desktop builder.

MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated
 
Link to the Builder
===================
1.https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/510
2.https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/510

Link to the log file
====================
1.https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin-clang%2F510%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout
2.https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin64-clang%2F510%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout

Error Log
==========
[  FAILED  ] MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated, where TypeParam =  and GetParam() =  (981 ms)
[2181/2181] MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated (1018 ms)
Retrying 1 test (retry #3)
[ RUN      ] MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated
[15372:8608:1127/234536.057:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[15372:8608:1127/234536.057:ERROR:service_manager.cc(890)] Failed to resolve service name: metrics
DevTools listening on ws://127.0.0.1:60731/devtools/browser/c4407a57-595f-4858-8851-9309f64c678c
[15372:8608:1127/234536.103:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[15372:8608:1127/234536.103:ERROR:service_manager.cc(890)] Failed to resolve service name: metrics
../../content/browser/renderer_host/input/mouse_latency_browsertest.cc(284): error:       Expected: 2
To be equal to: i.second
      Which is: 1
[  FAILED  ] MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated, where TypeParam =  and GetParam() =  (977 ms)
[2182/2182] MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated (1015 ms)
1 test failed:
    MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated (../../content/browser/renderer_host/input/mouse_latency_browsertest.cc:244)
<Thread(Thread-1, started 2416)> ProcessRead: proc.stdout finished.
<Thread(Thread-1, started 2416)> ProcessRead: cleaning up.
<Thread(Thread-2, started daemon 11112)> TimedFlush: Finished
<Thread(Thread-1, started 2416)> ProcessRead: finished.
C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\python.exe C:\b\rr\tmp7tjxkx\rw\checkout\recipes\.recipe_deps\depot_tools\gsutil.py -- cp file://c:\users\chrome~1\appdata\local\temp\tmpktyadu gs://chrome-gtest-results/raw/2017/11/27/28/5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz
Copying file://c:\users\chrome~1\appdata\local\temp\tmpktyadu [Content-Type=application/octet-stream]...
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 0 B/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 72 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 144 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 216 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 288 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 360 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 432 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 504 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 576 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 648 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 720 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 792 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 928 KiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 1.04 MiB/1.16 MiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 1.16 MiB/1.16 MiB    
C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\python.exe C:\b\rr\tmp7tjxkx\rw\checkout\recipes\.recipe_deps\depot_tools\gsutil.py -- cp file://c:\users\chrome~1\appdata\local\temp\tmpktyadu gs://chrome-gtest-results/buildbot/official.desktop/win-clang/510/content_browsertests.json.gz
Copying file://c:\users\chrome~1\appdata\local\temp\tmpktyadu [Content-Type=application/octet-stream]...
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 0 B/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 72 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 144 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 216 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 288 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 360 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 432 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 504 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 576 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 648 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 720 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 792 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 928 KiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 1.04 MiB/1.16 MiB    
Uploading   ...sktop/win-clang/510/content_browsertests.json.gz: 1.16 MiB/1.16 MiB    
C:\b\depot_tools\win_tools-2_7_6_bin\python\bin\python.exe C:\b\rr\tmp7tjxkx\rw\checkout\recipes\.recipe_deps\depot_tools\gsutil.py -- cp file://c:\users\chrome~1\appdata\local\temp\tmpmk8mnk gs://chrome-gtest-results/bigquery/2017/11/27/28/5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz
Copying file://c:\users\chrome~1\appdata\local\temp\tmpmk8mnk [Content-Type=application/octet-stream]...
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 0 B/51.42 KiB    
Uploading   ...5ee67f67a6a5bc1383dc0dfe7a11281cfac7fbf1.json.gz: 51.42 KiB/51.42 KiB    
exit code (as seen by runtest.py): 1
Confused: 58 files were deleted from c:\users\chrome~1\appdata\local\temp during the test run
step returned non-zero exit code: 1

Regression Information:
==========================
First Bad Build: https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/820
Last Good Build: https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/819
Flaky Information
Build ranges checked for flakiness: 779 : 828
Number of times failed: 4 times out of 47 builds.

Unable to find the actual suspect, hence assigning to the file owner 'mouse_latency_browsertest.cc' for more updates on this issue
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/OWNERS?sq=package:chromium&dr

dtapuska@ Could you please take a look in to this issue?

Thanks!
 
Cc: ligim...@chromium.org
Summary: MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated fails in Win Clang and ASAN for official.desktop builder (was: MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated fails in Win Clang and Win64 Clang builds for official.desktop builder)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb79dc9defdfa3ea23441bd7a14404d862952137

commit fb79dc9defdfa3ea23441bd7a14404d862952137
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 29 13:35:23 2017

Fix rAF aligned mouse input in background extensions.

Change https://chromium-review.googlesource.com/791031
missed a variable that was switching off the initialization of
mouse rAF aligned events. Keep the variable around since
it seems to be used for extensions.

BUG= 703344 , 789336 , 789096 
TBR=mustaq@chromium.org

Change-Id: Ia9e23bc59fa9903f1413ca43e153843280d7805d
Reviewed-on: https://chromium-review.googlesource.com/795451
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520093}
[modify] https://crrev.com/fb79dc9defdfa3ea23441bd7a14404d862952137/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/fb79dc9defdfa3ea23441bd7a14404d862952137/content/renderer/input/main_thread_event_queue.h

Cc: dtapu...@chromium.org
 Issue 789498  has been merged into this issue.

Comment 4 by hbos@chromium.org, Nov 29 2017

 Issue 789516  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec19588f22ed9413ff2095db5109453d536ace02

commit ec19588f22ed9413ff2095db5109453d536ace02
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Nov 29 15:13:52 2017

Disable CoalescedMouseMovesCorrectlyTerminated on all platforms

Failures have been detected on multiple platforms, removing the
conditional to only disable on Linux.

TBR=dtapuska@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  789096 
Change-Id: I725cf5059b19cf7eaba1e09a0f45097c1e74b223
Reviewed-on: https://chromium-review.googlesource.com/796831
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520113}
[modify] https://crrev.com/ec19588f22ed9413ff2095db5109453d536ace02/content/browser/renderer_host/input/mouse_latency_browsertest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b9f80d97e25ecca76ae8cbf4287ecbd677cd225

commit 4b9f80d97e25ecca76ae8cbf4287ecbd677cd225
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Dec 04 17:53:58 2017

Fix flaky MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated

We were not waiting for the GPU to finish its swap before stopping
the tracing. Hook up some listeners to latency info coming back
and terminate the run loop when we find the terminal component we
are looking for.

BUG= 789096 

Change-Id: I2b8336b8568c8d513d60f2314c4a3b7703416a66
Reviewed-on: https://chromium-review.googlesource.com/802017
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521383}
[modify] https://crrev.com/4b9f80d97e25ecca76ae8cbf4287ecbd677cd225/content/browser/renderer_host/input/mouse_latency_browsertest.cc
[modify] https://crrev.com/4b9f80d97e25ecca76ae8cbf4287ecbd677cd225/content/browser/renderer_host/render_view_host_factory.cc
[modify] https://crrev.com/4b9f80d97e25ecca76ae8cbf4287ecbd677cd225/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/4b9f80d97e25ecca76ae8cbf4287ecbd677cd225/testing/buildbot/filters/viz.content_browsertests.filter
[modify] https://crrev.com/4b9f80d97e25ecca76ae8cbf4287ecbd677cd225/ui/latency/latency_info.h

Status: Fixed (was: Assigned)

Sign in to add a comment