New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

ExtensionSettings description too long

Project Member Reported by pastarmovj@chromium.org, Nov 28 2017

Issue description

The description for the "ExtensionSettings" policy is too long and doesn't load properly as ADM file. It seems to not prevent the use of the templates but is rather annoying.

My suggestion would be to create a new help page like https://www.chromium.org/administrators/policy-list-3/user-data-directory-variables that describes the format of the policy and reference it from the policy text. like it is done for the UserDataDir https://www.chromium.org/administrators/policy-list-3#UserDataDir

We can't merge this fix back because it will have to go in all languages but let's aim for the next possible release.
 
M64-EnterPreise-Screenshot.png
570 KB View Download
Sure, sounds reasonable.

I'm not sure how to upload to https://www.chromium.org/administrators/policy-list-3/. Is there someone you can point me toward that can help out with that?
Do you want to create a new article on https://www.chromium.org/administrators? You can sign in there with your chromium.org account and this should give you rights to create/edit pages. You don't have to manually update the policy list itself though it will pick up the modified text from policy_templates.json just add a new page documenting the format of this policy and reference it from the text in policy_templates.json so that this reference appear in the GPO templates as well. 
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5710f8d7a584898c5e9d2caf5dc00f71d268e790

commit 5710f8d7a584898c5e9d2caf5dc00f71d268e790
Author: Nick Peterson <nrpeter@chromium.org>
Date: Wed Dec 06 18:17:00 2017

Shorten ExtensionSettings policy description.

The description for the ExtensionSettings policy exceeds the
 maximum size for Windows GPO templates. Move the full description
 to a seperate page on chromium.org and include a link here to
 the full description.

Bug:  789087 
Change-Id: Ia56d861af49981b5eac8da57b63ad65040cff3bc
Reviewed-on: https://chromium-review.googlesource.com/810106
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nick Peterson <nrpeter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522140}
[modify] https://crrev.com/5710f8d7a584898c5e9d2caf5dc00f71d268e790/components/policy/resources/policy_templates.json

Status: Fixed (was: Assigned)
Cc: kkaluri@chromium.org
Status: Assigned (was: Fixed)
nrpeter@ I could see this error on #64.0.3282.71 while loading the chrome.adm template

Could you please look into this...

Comment 6 by nrpeter@google.com, Jan 3 2018

Labels: Merge-Request-64
This patch is applied in M65, it wasn't merged back to M64. I'll request that now since this is a pretty small change and very visible to users.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 3 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64. Branch:3282
Labels: -Merge-Approved-64 Merge-Rejected-64
Since it affects policy_templates file, and this hasn't been merged yet, and too late now for translation, let's punt this to M65. 
Just to update, this issue is seen on latest chrome dev #65.0.3325.51

Did you download the ADMX templates from the following URL or somewhere else?
https://support.google.com/chrome/a/answer/187202?hl=en


I'm not sure what system bundles the ADMX templates and uploads them to the site above. Julian may know more about how that is handled. I'd guess that they use whatever ADMX templates are in stable at the time.
Cc: rogerta@chromium.org
Roger can you help figure out why the ADM[X] templates have not picked up the fix from Nick? Maybe it landed too late. Either way we might need to manually upload a newer version once more as this is not nice that the templates produce this error (even if you can click it away).
Status: Fixed (was: Assigned)
Downloaded the latest ADMX template zip and it loads fine. Looks like the description change is live.

Sign in to add a comment