New issue
Advanced search Search tips

Issue 789081 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Network Service: fast/dom/HTMLAnchorElement/anchor-download.htm started to fail

Project Member Reported by kinuko@chromium.org, Nov 28 2017

Issue description

HTMLAnchorElement download tests started to fail probably after 
r519463 (downloadmanager change)

* fast/dom/HTMLAnchorElement/anchor-download.html
* fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9351c4ba946f6a16f042854ce1050b5464f980f

commit e9351c4ba946f6a16f042854ce1050b5464f980f
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Nov 28 09:36:52 2017

Update WebKit LayoutTests filter for NetworkService

HTMLAnchorElement download tests started to fail probably after
r519463 (downloadmanager change)

* fast/dom/HTMLAnchorElement/anchor-download.html
* fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

TBR=qinmin@chromium.org
NOTRY=true

Bug:  789081 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia690b83acabd68971a71d8755411f37222700557
Reviewed-on: https://chromium-review.googlesource.com/792772
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519626}
[modify] https://crrev.com/e9351c4ba946f6a16f042854ce1050b5464f980f/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a56735dd6e5fe12104c18564e98a1209ed95f30

commit 4a56735dd6e5fe12104c18564e98a1209ed95f30
Author: Min Qin <qinmin@chromium.org>
Date: Tue Nov 28 19:14:48 2017

Pass correct render_process_id and render_frame_id when begin context menu download

The values are not set correctly, causing some tests to fail

BUG= 789081 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9619e747ba87f376bddbd3bf9b5275e495d74fe0
Reviewed-on: https://chromium-review.googlesource.com/794012
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519782}
[modify] https://crrev.com/4a56735dd6e5fe12104c18564e98a1209ed95f30/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/4a56735dd6e5fe12104c18564e98a1209ed95f30/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/4a56735dd6e5fe12104c18564e98a1209ed95f30/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 3 by qin...@chromium.org, Nov 28 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment