Stop mounting zip files automatically after sign out and sign in |
||||||||||||||||||||
Issue descriptionCurrently the ZIP unpacker extension mounts the mounted zip file the last session automatically upon sign-in. It is because File System Provider API works that way. It can sometimes block the UI at the startup when the extension works wrong or the file mounted by the extension is huge. So we think that at least ZIP files should be all unmounted upon sign out.
,
Nov 28 2017
Issue 787165 has been merged into this issue.
,
Nov 28 2017
,
Nov 28 2017
,
Nov 28 2017
Note: ZIP unpacker also needs an update to stop persisting volume. Parameters to chrome.fileSystemProvider.mount must not contain undefined field or it will fail by runtime error. So we must update ZIP unpacker after the client is updated with https://chromium-review.googlesource.com/c/chromium/src/+/792692 .
,
Nov 29 2017
> Parameters to chrome.fileSystemProvider.mount must not contain undefined field or it will fail by runtime error. Can't we ignore undefined field (|persistent| property) by modifying the implementation of chrome.fileSystemProvider.mount?
,
Nov 29 2017
I guess that is the design decision of the API made in the past. If we change it to allow undefined fields (even when we output warnings to the console), extensions may continue to work in an unintended way when a developer misspells some of the field names. So I'd like to have opinions from those who made it in the past on this point.
,
Nov 29 2017
Hi Tomasz, Is it intentional that loading new FSP extension with a new field (like "persistent": true) on old Chrome OS results in a runtime error? If so, is there a good practice for FSP developers to use the new field and keep the support for old Chrome at the same time? (Should we provide two extension versions with different "minimum_chrome_version"?)
,
Nov 29 2017
It's intentional. Sometimes new APIs will not be available on older systems. And I think it's not that uncommon, especially on he web. The auto-generated documentation on developer.chrome.com clearly states that some APIs are available from XX milestone. So we could use navigator.userAgent to check the Chrome OS version and pass the option if available. Parsing userAgent is not that straightforward but I don't really have a better idea right now. I wish we had Chrome version explicitly passed via Chrome app APIs.
,
Nov 29 2017
Thank you for the explanation! I thought "persistent" was added to the manifest, and I was confused...m(_ _)m I'll make sure that the new version of ZIP unpacker uses persistent field only when it is available.
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9 commit 00911ddd8e9f0476e2f1a1030bfc61a27f1891d9 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Nov 30 06:25:54 2017 Stop persisting zip file volume mounted by Zip Archiver. This adds "persistent" flag to MountOptions in the file system provider API, so that extensions can choose to mount filesystem only in the current sign-in session. Bug: 789073 Test: unit_tests --gtest_filter=FileSystemProviderServiceTest.* Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1e5f4249e915ca67622fac8ea50a8edd72408b8 Reviewed-on: https://chromium-review.googlesource.com/792692 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520462} [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/chromeos/file_system_provider/registry.cc [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/chromeos/file_system_provider/service.cc [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/chromeos/file_system_provider/service_unittest.cc [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/00911ddd8e9f0476e2f1a1030bfc61a27f1891d9/chrome/common/extensions/api/file_system_provider.idl
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/apps/unpacker/+/a0255140d0f116637e8c5e8b527cc6d8bdaa0dd1 commit a0255140d0f116637e8c5e8b527cc6d8bdaa0dd1 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Mon Dec 04 09:25:44 2017 Prevent mounting the volume after sign out and signing in again. 'persistent' parameter is added by https://chromium-review.googlesource.com/c/chromium/src/+/792692 and will be available from Chrome version 64. BUG= chromium:789073 TEST=Confirmed that zip files mounted in the prev session was not mounted after restart. Change-Id: Ib255fd364a714947da54ba7e1e2a3d9785d22b94 [modify] https://crrev.com/a0255140d0f116637e8c5e8b527cc6d8bdaa0dd1/unpacker/js/app.js
,
Dec 5 2017
Should be verified after the ZIP unpacker extension updated to version 0.77. 1. Open a zip file (so that the extension starts to run) 2. chrome://inspect/#Extensions 3. Find "ZIP unpacker" and click "inspect" 4. Go to "console" tab in the Developer Tools window 5. type "chrome.runtime.getManifest().version" and Enter.
,
Dec 5 2017
The step-by-step instruction I wrote in #13 is a way to see the version number of the extension.
,
Dec 5 2017
Let's keep this issue open until we update ZIP unpacker to disable persistent flag. We don't have a plan to ship ToT ZIP unpacker, so the commit in Comment 12 will not fix the issue by itself. I'll cherry-pick the change on the current version of ZIP unpacker and publish it as version 0.76.3.
,
Dec 7 2017
The updated ZIP unpacker (0.76.3) was published to M64+ devices. Marking this as Fixed.
,
Dec 28 2017
Verified on M65 dev build (Chrome OS 10257.0.0, 65.0.3299.0).
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3169366954d82dc6b35ad6a869907cde0d714cd commit c3169366954d82dc6b35ad6a869907cde0d714cd Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Jan 24 07:10:57 2018 Zip Archiver: Disable storing mount and password info. We are not restoring mount files at session restart anymore. Therefore the mount information and passwords should not be persisted. Othrewise it will be persisted until the user opens the same archive again manually after a long time and the files will be opened without requiring passwords. Bug: 789073 , 803752 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idadcff694b20109eb7e31710b57d88400601d30a Reviewed-on: https://chromium-review.googlesource.com/876705 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#531467} [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js [modify] https://crrev.com/c3169366954d82dc6b35ad6a869907cde0d714cd/chrome/browser/resources/chromeos/zip_archiver/manifest.json
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/506649901dd54feac291f89518bf86c8ae6f5b57 commit 506649901dd54feac291f89518bf86c8ae6f5b57 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Feb 01 07:11:33 2018 Zip Archiver: Disable storing mount and password info. We are not restoring mount files at session restart anymore. Therefore the mount information and passwords should not be persisted. Othrewise it will be persisted until the user opens the same archive again manually after a long time and the files will be opened without requiring passwords. Bug: 789073 , 803752 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idadcff694b20109eb7e31710b57d88400601d30a Reviewed-on: https://chromium-review.googlesource.com/876705 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531467}(cherry picked from commit c3169366954d82dc6b35ad6a869907cde0d714cd) Reviewed-on: https://chromium-review.googlesource.com/897284 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#227} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js [modify] https://crrev.com/506649901dd54feac291f89518bf86c8ae6f5b57/chrome/browser/resources/chromeos/zip_archiver/manifest.json
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92067a9e7c3867cbfb832dd8d953a4ec54a59238 commit 92067a9e7c3867cbfb832dd8d953a4ec54a59238 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Feb 22 03:47:06 2018 Revert "Zip Archiver: Disable storing mount and password info." This reverts commit c3169366954d82dc6b35ad6a869907cde0d714cd. Reason for revert: This caused regression Issue 812123 . This had caused that mount resuming succeeds superficially by the caller despite it actually failed, thus leaving inaccessible zip mount point. Original change's description: > Zip Archiver: Disable storing mount and password info. > > We are not restoring mount files at session restart anymore. > Therefore the mount information and passwords should not be persisted. > Othrewise it will be persisted until the user opens the same archive > again manually after a long time and the files will be opened without > requiring passwords. > > Bug: 789073 , 803752 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Idadcff694b20109eb7e31710b57d88400601d30a > Reviewed-on: https://chromium-review.googlesource.com/876705 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yuki Awano <yawano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531467} TBR=yawano@chromium.org,yamaguchi@chromium.org Bug: 789073 , 803752 Change-Id: I387e16717b5187389d01c5d5bc4a8b6884dcf035 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/928063 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538338} [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js [modify] https://crrev.com/92067a9e7c3867cbfb832dd8d953a4ec54a59238/chrome/browser/resources/chromeos/zip_archiver/manifest.json
,
Feb 22 2018
Reopening as the fix has been reverted on master.
,
Feb 22 2018
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0dfedfad98409de991ecadf83e31f47a2a47f82 commit c0dfedfad98409de991ecadf83e31f47a2a47f82 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Feb 23 01:42:48 2018 Revert "Zip Archiver: Disable storing mount and password info." This reverts commit c3169366954d82dc6b35ad6a869907cde0d714cd. Reason for revert: This caused regression Issue 812123 . This had caused that mount resuming succeeds superficially by the caller despite it actually failed, thus leaving inaccessible zip mount point. Original change's description: > Zip Archiver: Disable storing mount and password info. > > We are not restoring mount files at session restart anymore. > Therefore the mount information and passwords should not be persisted. > Othrewise it will be persisted until the user opens the same archive > again manually after a long time and the files will be opened without > requiring passwords. > > Bug: 789073 , 803752 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Idadcff694b20109eb7e31710b57d88400601d30a > Reviewed-on: https://chromium-review.googlesource.com/876705 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Yuki Awano <yawano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531467} TBR=yawano@chromium.org,yamaguchi@chromium.org Bug: 789073 , 803752 Change-Id: I387e16717b5187389d01c5d5bc4a8b6884dcf035 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/928063 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538338}(cherry picked from commit 92067a9e7c3867cbfb832dd8d953a4ec54a59238) Bug: 812123 Change-Id: I387e16717b5187389d01c5d5bc4a8b6884dcf035 Reviewed-on: https://chromium-review.googlesource.com/933681 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#565} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js [modify] https://crrev.com/c0dfedfad98409de991ecadf83e31f47a2a47f82/chrome/browser/resources/chromeos/zip_archiver/manifest.json
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f37067abf1c72034a574101ba34ef7c6471d8057 commit f37067abf1c72034a574101ba34ef7c6471d8057 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Feb 23 06:12:11 2018 Zip Archiver: Stop memorizing and remembering zip passwords. This is a partial reland of 876705. Since the extension mounts files with persistent:false, remembering passwords (for reboot/suspend) does not have any intended effect. Therefore this change removes the "remember" checkbox for the password input UI and stops remembering new passwords of encrypted files in ZIP files. This change also stops using remembered passwords by old versions of the extension. As a remaining issue after this, when there is already memorized mount info by older versions of the extension, it will still mount the zip file upon reboot/suspend until user successfully unmounts it. Bug: 789073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibaa2afd21dbbebfa67f2e5616913313be9ad518e Reviewed-on: https://chromium-review.googlesource.com/930644 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538711} [modify] https://crrev.com/f37067abf1c72034a574101ba34ef7c6471d8057/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/f37067abf1c72034a574101ba34ef7c6471d8057/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/f37067abf1c72034a574101ba34ef7c6471d8057/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/f37067abf1c72034a574101ba34ef7c6471d8057/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js [modify] https://crrev.com/f37067abf1c72034a574101ba34ef7c6471d8057/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js
,
Feb 26 2018
We'd like to merge https://chromium-review.googlesource.com/930644 to M65. It is a partial reland of the change once reverted to fix the regression.
,
Feb 26 2018
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 27 2018
,
Feb 28 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd593a368c24a92baaf499351a7c2f53cf05b8f5 commit bd593a368c24a92baaf499351a7c2f53cf05b8f5 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Feb 28 02:25:50 2018 Zip Archiver: Stop memorizing and remembering zip passwords. This is a partial reland of 876705. Since the extension mounts files with persistent:false, remembering passwords (for reboot/suspend) does not have any intended effect. Therefore this change removes the "remember" checkbox for the password input UI and stops remembering new passwords of encrypted files in ZIP files. This change also stops using remembered passwords by old versions of the extension. As a remaining issue after this, when there is already memorized mount info by older versions of the extension, it will still mount the zip file upon reboot/suspend until user successfully unmounts it. Bug: 789073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibaa2afd21dbbebfa67f2e5616913313be9ad518e Reviewed-on: https://chromium-review.googlesource.com/930644 Reviewed-by: Yuki Awano <yawano@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#538711}(cherry picked from commit f37067abf1c72034a574101ba34ef7c6471d8057) Reviewed-on: https://chromium-review.googlesource.com/940741 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#619} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/bd593a368c24a92baaf499351a7c2f53cf05b8f5/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css [modify] https://crrev.com/bd593a368c24a92baaf499351a7c2f53cf05b8f5/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html [modify] https://crrev.com/bd593a368c24a92baaf499351a7c2f53cf05b8f5/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/bd593a368c24a92baaf499351a7c2f53cf05b8f5/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-dialog.js [modify] https://crrev.com/bd593a368c24a92baaf499351a7c2f53cf05b8f5/chrome/browser/resources/chromeos/zip_archiver/js/passphrase-manager.js
,
Feb 28 2018
,
Mar 2 2018
The current target milestone for this feature is M-66. Weifang, please correct me if I'm wrong. Thanks!
,
Mar 2 2018
To confirm, at this moment M65 doesn't memorize new ones, but doesn't automatically forget mounted archives by older versions. - A zip file opened on M65 will not be mounted automatically upon sign-in or resume from suspend anymore. - A zip file that was opened on M64- but never unmounted by user, will still be mounted automatically upon (sign-in) or (resume from suspend), until user successfully unmounts it manually once. The latter case is targeted by M-66. Please correct us if it's wrong. Thanks!
,
Mar 2 2018
That works. Thanks both!!
,
Mar 9 2018
Moving to M-67, please update if incorrect.
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8781418ce126ab08de6a82eef749d4c3bef5080 commit f8781418ce126ab08de6a82eef749d4c3bef5080 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Wed Mar 14 11:10:42 2018 Zip Archiver: Stop persisting mount info. Make Zip Archiver to forget password when requested to resume, as well as returning error to make VolumeManager remove the persisted provided volume info. Remove all code for persisting zip mount state. Bug: 789073 , 803752 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb9a6e9ca04b7ed633480a17973d1dcb126d02e0 Reviewed-on: https://chromium-review.googlesource.com/940742 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#543048} [modify] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/chrome/browser/resources/chromeos/zip_archiver/js/decompressor.js [modify] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/chrome/browser/resources/chromeos/zip_archiver/js/main.js
,
Mar 26 2018
There is an existing minor case which is not handled yet. - ZIP unpacker mounting archive before M63 and it's still persisted. I think this is not necessary to fix right now, but rather should be resolved by fading out the extension ( Issue 821761 ). So marking this as fixed. - impact: limited. Only the user who have mounted file before M63 and still having it mounted, will be affected. Also, those files behave same as before. - workaround 1: if user can login and use the Files app normally, user can unmount it. - workaround 2: if user have cannot use the Files app normally (e.g. due to mounted large zip file blocking the app start sequence), removing and adding the user profile will reset it.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83eea24bb70cd3acb379a92e45003e5aa03075a7 commit 83eea24bb70cd3acb379a92e45003e5aa03075a7 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Tue May 08 11:59:09 2018 Prevent runtime errors on suspend events. unpacker.app.onSuspend was removed at f878141 and no longer exists. https://chromium-review.googlesource.com/940742 Bug: 839158 , 789073 , 803752 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I973b7728095cddcceab2e58c06ca07986a6bd9e6 Reviewed-on: https://chromium-review.googlesource.com/1049417 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#556763} [modify] https://crrev.com/83eea24bb70cd3acb379a92e45003e5aa03075a7/chrome/browser/resources/chromeos/zip_archiver/js/background.js |
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by yamaguchi@chromium.org
, Nov 28 2017