Notification - action button clicks are not unit tested |
|||
Issue descriptionAction button clicks in NotificationView and NotificationViewMD are not unit tested. It is better to unit test them.
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/848163c8e1950ff19c9b65900dcfd5f7e8f4a981 commit 848163c8e1950ff19c9b65900dcfd5f7e8f4a981 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Dec 01 03:31:34 2017 Add unit tests for action button click and inline reply. User interaction with NotificationViewMD should fire the appropriate callback methods defined in MessageViewDelegate. Especially, with the interaction in the actions row, we should fire - ClickOnNotificationButon - ClickOnNotificationButtonWithReply This CL adds the following unit tests to test these callbacks. - TestActionButtonClick - TestInlineReply TEST=message_center_unittests BUG= 789057 Change-Id: Iba71e1f928830071fe73a7e49feb44efe493c8dd Reviewed-on: https://chromium-review.googlesource.com/799592 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#520837} [modify] https://crrev.com/848163c8e1950ff19c9b65900dcfd5f7e8f4a981/ui/message_center/views/notification_view_md.h [modify] https://crrev.com/848163c8e1950ff19c9b65900dcfd5f7e8f4a981/ui/message_center/views/notification_view_md_unittest.cc
,
Dec 1 2017
,
Jul 30
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tetsui@chromium.org
, Nov 30 2017