UsersLRUInputMethod uses non-canonical keys. |
|||||
Issue descriptionWe need to migrate UsersLRUInputMethod to known_users.
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc99618a31f21158595a52d0e3caf51e5b1e3b4 commit 5dc99618a31f21158595a52d0e3caf51e5b1e3b4 Author: Colin Blundell <blundell@chromium.org> Date: Fri Jan 12 07:30:15 2018 Convert components/suggestions to use Identity Service client library This CL converts //components/suggestions from using //components/signin to using the Identity Service client library. The conversion is straightforward: - Create PrimaryAccountAccessTokenFetcher via IdentityManager rather than directly. I tested the relevant behavior manually by going to the NTP and chrome://suggestions for a signed-in and syncing test user on Linux/Android and confirming that their NTP tiles showed up after this change identically to before this change. Followup changes will introduce FakeIdentityManager and change suggestions_service_impl_unittest.cc to use FakeIdentityManager rather than using the underlying signin fakes. Bug: 789049 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d2c84261552eb79390e009ae7331c5f3a8161e5 Reviewed-on: https://chromium-review.googlesource.com/847485 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#528901} [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/components/suggestions/BUILD.gn [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/components/suggestions/suggestions_service_impl.cc [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/components/suggestions/suggestions_service_impl.h [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/components/suggestions/suggestions_service_impl_unittest.cc [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/ios/chrome/browser/suggestions/BUILD.gn [modify] https://crrev.com/5dc99618a31f21158595a52d0e3caf51e5b1e3b4/ios/chrome/browser/suggestions/suggestions_service_factory.mm
,
Sep 28
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
,
Oct 5
,
Oct 16
,
Oct 16
Jacob, could you help finding owner for this?
,
Jan 4
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by alemate@chromium.org
, Nov 28 2017