New issue
Advanced search Search tips

Issue 789039 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Get rid of Position::EditingPositionOf()

Project Member Reported by yosin@chromium.org, Nov 28 2017 
EditingPositionOf() is introduced for creating OffsetInAnchor position, but it
does more.

Because of most of EditingPositonOf() call sites take canonicalized position,
we don't need to use.

Let's see layout test failures and understand the reason of failures then
update layout test expectations.

Comment 1 by xiaoche...@chromium.org, Nov 28 2017

Labels: -Type-Bug Type-Task
EditingPositionOf() doesn't seem too hacky. It's just handling of EditingIgnoresContent:

If |!EditingIgnoresContent(*anchor_node)|, return Position(anchor_node, offset)

Otherwise, return anchor_node@BeforeAnchor or anchor_node@AfterAnchor, depending on the value of |offset|

Do we really want to get rid of this function? Or just rename it with a more intuitive name + better comments?

Comment 2 by xiaoche...@chromium.org, Nov 29 2017

Components: -Blink>Editing>Selection Blink>Editing
Discussed offline with yosin@. Summary:

While position fixup may be necessary, EditingPositionOf() is currently being abused. Not all callers really need the fixup (e.g., NextBoundary()).

We should start with investigating and pruning the callers.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 30

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by yosin@chromium.org, Jan 10

Status: Available (was: Untriaged)
►

Sign in to add a comment