New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789031 link

Starred by 3 users
Status: Available
Owner:
█ dvallet@chromium.org
Last visit 29 days ago
Cc:
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug
Build-Toolchain



Sign in to add a comment

Remove check for __NR_memfd_create availability once is supported in ChromeOS

Project Member Reported by dvallet@chromium.org, Nov 28 2017 
For now we need to protect the new implementation of shared memory using memfd_create for ChromeOS builds. 

#if defined(__NR_memfd_create)

Once this is available, we should be able to remove this check for Chrome builds in Linux environments.

Comment 1 by thestig@chromium.org, Nov 29 2017 

As I mentioned on the CL related to this issue, the system or sysroot header on ChromeOS should have __NR_memfd_create defined, yet somehow it doesn't work on try bots.

Someone needs to sufficiently replicate the ChromeOS try bot build environment such that they can break the local build by removing the __NR_memfd_create check. Then they can examine the build flags and build environment to see if this issue is something silly like a missing #include, or if there is some build environment change that this issue depends on.

Comment 2 by zalcorn@chromium.org, Nov 16

Components: Infra>Platform>Buildbot

Comment 3 by no...@chromium.org, Nov 16

Components: -Infra>Platform>Buildbot Infra>Client>ChromeOS>Build

Comment 4 by vapier@chromium.org, Nov 16

Components: -Infra>Client>ChromeOS>Build OS>Kernel Tools>ChromeOS-Toolchain
Owner: dvallet@chromium.org
CrOS toolchain has linux-4.14 headers now in master for all targets.  so whatever cleanup you want to do is probably possible now.
►

Sign in to add a comment