New issue
Advanced search Search tips

Issue 788979 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 2017
Cc:
rdevlin....@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] Toolbar oveflowing before transitioning to "narrow" mode.

Project Member Reported by dpa...@chromium.org, Nov 28 2017 
Repro steps (see screencast):

1) Gradually decrease the width of the window
2) Notice that the toggle control on the right falls outside of the viewport before the toolbar collapses to narrow mode.

Need to force the toolbar to transition to narrow mode faster for MD Extensions, since there are more items on the right side of the toolbar than other pages. 

Note that currently the width at which the toolbar decides to became narrow is hard-coded to 900px and not configurable from the outside, see https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html?l=158.

Comment 1 by dpa...@chromium.org, Nov 28 2017

toolbar_oveflowing.mp4
1.2 MB View Download

Comment 2 by dpa...@chromium.org, Nov 29 2017

Cc: rdevlin....@chromium.org
 Issue 789681  has been merged into this issue.

Comment 3 by dpa...@chromium.org, Nov 30 2017

Owner: dpa...@chromium.org
Status: Started (was: Available)

Comment 4 by dpa...@chromium.org, Nov 30 2017 

Before/after screencast attached. CL at https://chromium-review.googlesource.com/c/chromium/src/+/801796.
toolbar_collapse.mp4
3.8 MB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f30f288a509d687db5d9878c2874905197d3ed

commit 65f30f288a509d687db5d9878c2874905197d3ed
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 30 21:49:01 2017

MD Extensions: Force the toolbar to narrow mode sooner.

In other WebUIs the toolbar collapses when the window width fallows below 900px.
In MD Extensions, because there is more content on the right of the toolbar, it
needs to collapse sooner.

Bug:  788979 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I69617f871918ffcc462834827b116aef8f7ca0bf
Reviewed-on: https://chromium-review.googlesource.com/801796
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520704}
[modify] https://crrev.com/65f30f288a509d687db5d9878c2874905197d3ed/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/65f30f288a509d687db5d9878c2874905197d3ed/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/65f30f288a509d687db5d9878c2874905197d3ed/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js

Comment 6 by dpa...@chromium.org, Nov 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment