#enable-desktop-pwas doesn't always imply #enable-experimental-app-banners |
||
Issue description#enable-desktop-pwas should imply #enable-experimental-app-banners but doesn't here: https://cs.chromium.org/chromium/src/chrome/browser/banners/app_banner_manager.cc?rcl=597a74d4fcfd2f1918772cf843ce235394dfc80d&l=541 and here: https://cs.chromium.org/chromium/src/chrome/browser/banners/app_banner_manager_desktop.cc?rcl=1da3777815d2f91b045f85693d0fa3ff824b1646&l=34
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1db5a8837f62ff1551468eb74e37796bb248c834 commit 1db5a8837f62ff1551468eb74e37796bb248c834 Author: Michael McGreevy <mcgreevy@chromium.org> Date: Wed Nov 29 06:40:58 2017 Remove remaining direct references to kExperimentalAppBanners crrev.com/786357 replaced references to kExperimentalAppBanners with calls to IsExperimentalAppBannersEnabled(). A couple of other references to kExperimentalAppBanners were either missed, or were added since then. This CL switches them over too. Bug: 788974 Change-Id: I4e8a3a34ab81aec56e661c960255132c71f52300 Reviewed-on: https://chromium-review.googlesource.com/795494 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Cr-Commit-Position: refs/heads/master@{#520031} [modify] https://crrev.com/1db5a8837f62ff1551468eb74e37796bb248c834/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/1db5a8837f62ff1551468eb74e37796bb248c834/chrome/browser/banners/app_banner_manager_desktop.cc
,
Nov 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ortuno@chromium.org
, Nov 29 2017