New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788974 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

#enable-desktop-pwas doesn't always imply #enable-experimental-app-banners

Project Member Reported by mcgreevy@chromium.org, Nov 28 2017

Issue description

Comment 1 by ortuno@chromium.org, Nov 29 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db5a8837f62ff1551468eb74e37796bb248c834

commit 1db5a8837f62ff1551468eb74e37796bb248c834
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Wed Nov 29 06:40:58 2017

Remove remaining direct references to kExperimentalAppBanners

crrev.com/786357 replaced references to kExperimentalAppBanners with
calls to IsExperimentalAppBannersEnabled(). A couple of other references
to kExperimentalAppBanners were either missed, or were added since then.
This CL switches them over too.

Bug:  788974 
Change-Id: I4e8a3a34ab81aec56e661c960255132c71f52300
Reviewed-on: https://chromium-review.googlesource.com/795494
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520031}
[modify] https://crrev.com/1db5a8837f62ff1551468eb74e37796bb248c834/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/1db5a8837f62ff1551468eb74e37796bb248c834/chrome/browser/banners/app_banner_manager_desktop.cc

Status: Fixed (was: Assigned)

Sign in to add a comment