New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788943 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"Copy link address" in context menu without icon in Canary (in Dev OK)

Project Member Reported by mar...@mwiacek.com, Nov 27 2017

Issue description

Steps to reproduce the problem:
1. Enable new style for context menu
2. Open context menu for link

What is the expected behavior?
Icon in the left side of "Copy link address"

What went wrong?
Icon in the left side of "Copy link address" is not displayed

Did this work before? Yes 64.0.3271.3 dev

Chrome version: 64.0.3277.0  Channel: canary
OS Version: 7
Flash Version:
 
canary.png
825 KB View Download
dev.png
639 KB View Download
Labels: Needs-triage-Mobile
Cc: msrchandra@chromium.org nyerramilli@chromium.org ligim...@chromium.org sandeepkumars@chromium.org
Labels: -Pri-2 hasbisect-per-revision ReleaseBlock-Stable M-64 Triaged-Mobile Pri-1
Owner: melandory@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue in Android and could reproduce the issue. Make sure to enable the new custom context menu from the chrome://flags.

Steps Followed:
1. Launched Chrome Browser.
2. Navigated to random site
3. Long pressed on the link, Observed icon for Copy link address" is missing.

Chrome versions tested:
64.0.3278.7

OS
Android 7.0.0

Android Devices
7.0.0; SM-J710F Build/NRD90M

Below is the bisect info
=======================
Chrome Good Build -- 64.0.3276.0
Chrome Bad Build  -- 64.0.3277.0

Manual CL:
https://chromium.googlesource.com/chromium/src/+log/64.0.3276.0..64.0.3277.0?pretty=fuller&n=10000

You are looking for a change made after 518931(GOOD), but before 518932(BAD).

From the above revision range suspecting the following change have fixed the issue and assigning the issue to the owner concerned--
https://chromium.googlesource.com/chromium/src/+/9d661a14710220d9776c1815638201549198645b

@melandory -- Could you please look into the issue.

Please navigate to below link for log's and video--
go/chrome-androidlogs/788943

Adding Release Block Stable as this is a recent regression broken in M64.

Thanks!

Comment 3 by mar...@mwiacek.com, Dec 9 2017

can be closed
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f7ff427fbb82fc5663207098dc167203febfcd3

commit 5f7ff427fbb82fc5663207098dc167203febfcd3
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu Dec 14 12:59:22 2017

Reverting back to using png instead of xml for copy icon.

Copy icon from xml isn't displayed. FReverting to using png while
figuring out why this is happening.


Bug:  788943 
Change-Id: Ic2941708a27bfe1019b85db16bbf9fe8bc2137b0
Reviewed-on: https://chromium-review.googlesource.com/803278
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524049}
[modify] https://crrev.com/5f7ff427fbb82fc5663207098dc167203febfcd3/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/5f7ff427fbb82fc5663207098dc167203febfcd3/chrome/android/java/res/layout/password_entry_editor_interactive.xml
[modify] https://crrev.com/5f7ff427fbb82fc5663207098dc167203febfcd3/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java

Labels: Merge-Request-64
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 18 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25ea4099e3c77fdb8098a5d2f0512a479c47c8ce

commit 25ea4099e3c77fdb8098a5d2f0512a479c47c8ce
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Mon Dec 18 17:31:22 2017

Fix lint issues in PasswordEntryEditor

Duplicate resource id lookups in PasswordEntryEditor were
flagged by Android Linter and broke compilation. This CL fixes
them as well as some other warnings around unnecessary casts
and lambda conversions.

Bug:  788943 
Change-Id: I194b7c80e6ba5d0e37c4b5eba3c95488b4003a0b
Reviewed-on: https://chromium-review.googlesource.com/832406
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524733}
[modify] https://crrev.com/25ea4099e3c77fdb8098a5d2f0512a479c47c8ce/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java

Comment 8 by cmasso@google.com, Dec 18 2017

Please confirm this issue is fixed on canary

Comment 9 by mar...@mwiacek.com, Dec 20 2017

it is fixed
Labels: -Hotlist-Merge-Review -Merge-Review-64 Merge-Approved-64
melandory / dgn, reminder to please merge CL to M64 branch 3282.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 3 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a570a06d52dbf29f4c110de5054c48aa65d55c1

commit 4a570a06d52dbf29f4c110de5054c48aa65d55c1
Author: Tatiana Gornak <melandory@chromium.org>
Date: Wed Jan 03 11:56:13 2018

Reverting back to using png instead of xml for copy icon.

Copy icon from xml isn't displayed. FReverting to using png while
figuring out why this is happening.


TBR=melandory@chromium.org

(cherry picked from commit 5f7ff427fbb82fc5663207098dc167203febfcd3)

Bug:  788943 
Change-Id: Ic2941708a27bfe1019b85db16bbf9fe8bc2137b0
Reviewed-on: https://chromium-review.googlesource.com/803278
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524049}
Reviewed-on: https://chromium-review.googlesource.com/848974
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#394}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/4a570a06d52dbf29f4c110de5054c48aa65d55c1/chrome/android/java/res/layout/password_entry_editor_copyable_row.xml
[modify] https://crrev.com/4a570a06d52dbf29f4c110de5054c48aa65d55c1/chrome/android/java/res/layout/password_entry_editor_interactive.xml
[modify] https://crrev.com/4a570a06d52dbf29f4c110de5054c48aa65d55c1/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java

Status: Fixed (was: Assigned)
Closing since it's been merged.

Feel free to reopen if more work is needed here.

Sign in to add a comment