New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Remove bitrate/bandwidth estimation when trying to start media remoting

Project Member Reported by x...@chromium.org, Nov 27 2017

Issue description

When going fullscreen while tab mirroring a video, the behavior is unpredictable if the content bitrate changes (e.g., due to the site adaptive streaming).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cacf420c879ac198e2faa3c536cd953048e6381

commit 2cacf420c879ac198e2faa3c536cd953048e6381
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Wed Nov 29 02:22:50 2017

Media Remoting: Remove bitrate estimation.

The existing logic is to only start media remoting when the content
bitrate is less than the network bandwidth. This makes the behavior
unpredictable since the content bitrate might be varied, e.g., by
adaptive streaming. This CL removed the bitrate estimation to reduce
the unpredictability of the behavior when starting media remoting.

Bug:  788940 
Change-Id: Id933332b460785a8a516264f4764424e20903541
Reviewed-on: https://chromium-review.googlesource.com/791864
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519974}
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/media/base/media_observer.h
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/media/remoting/metrics.cc
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/media/remoting/metrics.h
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/media/remoting/renderer_controller.cc
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/media/remoting/renderer_controller.h
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/2cacf420c879ac198e2faa3c536cd953048e6381/tools/metrics/histograms/histograms.xml

Comment 2 by x...@chromium.org, Nov 29 2017

Status: Fixed (was: Started)

Sign in to add a comment