New issue
Advanced search Search tips

Issue 788939 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 764125



Sign in to add a comment

MD Extensions: A11y: Unlabelled buttons in detail view

Project Member Reported by hcarmona@chromium.org, Nov 27 2017 
1. Navigate to chrome://extensions
2. View deails of an extensions
3. The following buttons do not have labels:

    body > extensions-manager /deep/ #viewManager > extensions-detail-view /deep/ #allow-on-file-urls /deep/ #crToggle
    body > extensions-manager /deep/ #viewManager > extensions-detail-view /deep/ #allow-incognito /deep/ #crToggle
    body > extensions-manager /deep/ #viewManager > extensions-detail-view /deep/ #collect-errors /deep/ #crToggle
Unlabelled Toggles.png
7.5 KB View Download

Comment 1 by hcarmona@chromium.org, Nov 28 2017

Owner: hcarmona@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b3d8e33b0a9e07e708f345e66a219835ad8e9b

commit f5b3d8e33b0a9e07e708f345e66a219835ad8e9b
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Nov 28 18:50:09 2017

MD Extensions: A11y - Label extensions-toggle-row's cr-toggle.

Bug:  788939 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I29772945465558910f6aa8758939c5225a877383
Reviewed-on: https://chromium-review.googlesource.com/791829
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519769}
[modify] https://crrev.com/f5b3d8e33b0a9e07e708f345e66a219835ad8e9b/chrome/browser/resources/md_extensions/toggle_row.html

Comment 3 by hcarmona@chromium.org, Nov 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment